Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmedcon: init at 0.21.0 #115820

Merged
merged 1 commit into from Mar 25, 2021
Merged

xmedcon: init at 0.21.0 #115820

merged 1 commit into from Mar 25, 2021

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 10, 2021

This allows reading DICOM images, including 3d stacks.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from arianvp March 10, 2021 19:21
@flokli
xmedcon: init at 0.21.0
275cc4e 
This allows reading DICOM images, including 3d stacks.
@SuperSandro2000
Copy link
Member

@ofborg eval

@flokli
Copy link
Contributor Author

flokli commented Mar 23, 2021

ping @SuperSandro2000

@flokli flokli merged commit 7d19272 into NixOS:master Mar 25, 2021
@flokli flokli deleted the xmedcon branch March 25, 2021 22:02
SuperSandro2000
SuperSandro2000 reviewed Mar 26, 2021
View reviewed changes
pkgs/applications/science/medicine/xmedcon/default.nix
homepage = "https://xmedcon.sourceforge.io/Main/HomePage";
license = licenses.lgpl2Plus;
maintainers = with maintainers; [ arianvp flokli ];
platforms = with platforms; [ darwin linux ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be simplified to unix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@arianvp arianvp Awaiting requested review from arianvp

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @SuperSandro2000