Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak: 1.10.1 -> 1.10.2 #115837

Merged
merged 1 commit into from Mar 12, 2021
Merged

flatpak: 1.10.1 -> 1.10.2 #115837

merged 1 commit into from Mar 12, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/flatpak/flatpak/releases.

meta.description for flatpak is: "Linux application sandboxing and distribution framework"

meta.homepage for flatpak is: "https://flatpak.org/"

meta.changelog for flatpak is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
46 total rebuild path(s)

15 package rebuild(s)

15 x86_64-linux rebuild(s)
15 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
15 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
flatpak
flatpak-builder
gnome-builder
gnome3.gnome-software
libsForQt5.discover
libsForQt512.discover
libsForQt514.discover
libsForQt515.discover
malcontent-ui
pantheon.appcenter
pantheon.sideload
plasma5Packages.discover
vala-language-server
xdg-desktop-portal
xdg-desktop-portal-gtk
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/15bcgj2m7b77qz1lmy19gnvjq7806wkl-flatpak-1.10.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A flatpak https://github.com/r-ryantm/nixpkgs/archive/929b22d2176c5e3c50ede7e66a9db3c86a9d5832.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/15bcgj2m7b77qz1lmy19gnvjq7806wkl-flatpak-1.10.2
ls -la /nix/store/15bcgj2m7b77qz1lmy19gnvjq7806wkl-flatpak-1.10.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.discover
  • libsForQt514.discover
1 package failed to build:
  • pantheon.appcenter
10 packages built:
  • discover (libsForQt5.discover)
  • flatpak
  • flatpak-builder
  • gnome-builder
  • gnome3.gnome-software
  • malcontent-ui
  • pantheon.sideload
  • vala-language-server
  • xdg-desktop-portal
  • xdg-desktop-portal-gtk

Maintainer pings

cc @jtojnar for testing.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Mar 11, 2021
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • All dependencies don't build via nix-review, but the breakage was already on master
2 packages marked as broken and skipped:
libsForQt512.discover libsForQt514.discover

1 package failed to build:
pantheon.appcenter

10 packages built:
flatpak flatpak-builder gnome-builder gnome3.gnome-software libsForQt5.discover malcontent-ui pantheon.sideload vala-language-server xdg-desktop-portal xdg-desktop-portal-gtk

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed tests pass except for flatpak/test-summaries@system.wrap.test, which is an improvement.

@jtojnar jtojnar merged commit 4b6373a into NixOS:master Mar 12, 2021
@r-ryantm r-ryantm deleted the auto-update/flatpak branch March 12, 2021 20:06
@JoshuaFern
Copy link
Member

@jtojnar Could you please take a look at flathub/org.chromium.Chromium#81?

@jtojnar
Copy link
Contributor

jtojnar commented Mar 13, 2021

@JoshuaFern could you please open an issue? That looks like it is unrelated to this update.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 13, 2021

@JoshuaFern Actually, I think I know what is the problem. Could you please test if #116236 fixes it?

@jtojnar jtojnar mentioned this pull request Oct 17, 2021
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants