Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musescore: 3.6.1 -> 3.6.2 #115883

Closed
wants to merge 1 commit into from
Closed

musescore: 3.6.1 -> 3.6.2 #115883

wants to merge 1 commit into from

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Mar 11, 2021

Motivation for this change

Update to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from turion March 11, 2021 03:14
@turion
Copy link
Contributor

turion commented Mar 11, 2021

This MR and #115880 are duplicates. Which one should we close?

turion
turion reviewed Mar 11, 2021
View reviewed changes
pkgs/applications/audio/musescore/default.nix

src = fetchFromGitHub {
owner = "musescore";
repo = "MuseScore";
rev = "v${version}";
sha256 = "sha256-21ZI5rsc05ZWEyM0LeFr+212YViLYveZZBvVpskh8iA=";
hash = "sha256-GBGAD/qdOhoNfDzI+O0EiKgeb86GFJxpci35T6tZ+2s=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know it's possible to use the hash attribute

@yurrriq
Copy link
Member Author

yurrriq commented Mar 13, 2021

Duplicate of #115880

@yurrriq yurrriq marked this as a duplicate of #115880 Mar 13, 2021
@yurrriq yurrriq closed this Mar 13, 2021
@yurrriq yurrriq deleted the musescore-3.6.2 branch March 13, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turion turion turion left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurrriq @turion