Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom: Add global menu support #115908

Merged
merged 1 commit into from Mar 21, 2021
Merged

atom: Add global menu support #115908

merged 1 commit into from Mar 21, 2021

Conversation

greydot
Copy link
Contributor

@greydot greydot commented Mar 11, 2021

Motivation for this change

Add global menu support to Atom.

Things done

Added libdbusmenu dependency.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 11, 2021 •
edited

Result of nixpkgs-review pr 115908 at 0bcaa16 run on aarch64-linux 1

3 packages marked as broken and skipped:
  • electron_3
  • electron_4
  • electron_5
15 packages built successfully:

Result of nixpkgs-review pr 115908 at 0bcaa16 run on x86_64-linux 1

7 packages marked as broken and skipped:
  • atom-beta
  • electron_3
  • electron_4
  • electron_5
  • hyper-haskell
  • obinskit
  • termius
36 packages built successfully:

@SuperSandro2000 SuperSandro2000 merged commit e6b2664 into NixOS:master Mar 21, 2021
@greydot greydot deleted the atom-global-menu branch March 22, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysndr ysndr Awaiting requested review from ysndr

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greydot @r-rmcgibbo @SuperSandro2000