Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beets: fix lyrics dependency #115921

Merged
merged 1 commit into from Mar 11, 2021
Merged

beets: fix lyrics dependency #115921

merged 1 commit into from Mar 11, 2021

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Noticed this was missing during usage

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from doronbehar, aszlig and pjones March 11, 2021 11:28
@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 11, 2021 •
edited

Result of nixpkgs-review pr 115921 at 2a43b93 run on aarch64-linux 1

4 packages built successfully:

Result of nixpkgs-review pr 115921 at 2a43b93 run on x86_64-linux 1

4 packages built successfully:

@SuperSandro2000 SuperSandro2000 merged commit ad47086 into NixOS:master Mar 11, 2021
@lovesegfault lovesegfault deleted the beets-fix-deps branch March 11, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

@aszlig aszlig Awaiting requested review from aszlig

@pjones pjones Awaiting requested review from pjones

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @r-rmcgibbo @SuperSandro2000