Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonarr: 2.0.0.5344 -> 3.0.5.1144 #115944

Merged
merged 5 commits into from Mar 25, 2021
Merged

sonarr: 2.0.0.5344 -> 3.0.5.1144 #115944

merged 5 commits into from Mar 25, 2021

Conversation

andreisergiu98
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fadenb and purcell March 11, 2021 15:16
purcell
purcell approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@purcell purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andreisergiu98 @SuperSandro2000
sonarr: remove ellipses from arguments
65e68dc 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@ofborg ofborg bot requested a review from purcell March 12, 2021 09:50
purcell
purcell approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@purcell purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good, I also tested startup on darwin.

@tomberek
Copy link
Contributor

Functions on NixOS. Is there an update to platform?

@purcell
Copy link
Member

purcell commented Mar 14, 2021

Is there an update to platform?

Should still be fine, no?

@andreisergiu98
Copy link
Member Author

Is there an update to platform?

Nope, sonarr didn't move away from mono and it's not planning to do so any time soon.

@andreisergiu98
Copy link
Member Author

I looked through the PRs and I didn't find any created by the bot for the latest versions of Sonarr. So I created an update script and I think it will be more reliable than getting the version from https://repology.org/metapackage/sonarr/versions. What do you think?

@ofborg ofborg bot requested a review from purcell March 24, 2021 16:29
@purcell
Copy link
Member

purcell commented Mar 24, 2021

So I created an update script and I think it will be more reliable than getting the version from https://repology.org/metapackage/sonarr/versions. What do you think?

I guess one comment about grabbing the latest-versioned tag from github is that it might include pre-releases, which presumably we would not want. (I don't know how the bot works, or if it handles this.)

@purcell
Copy link
Member

purcell commented Mar 24, 2021 •
edited

In practice that might be a silly thing to worry about, because any resulting PRs could simply be closed.

@andreisergiu98
Copy link
Member Author

So far sonarr tagged only stable releases, but if this changes in the future maybe we can filter them if the naming will follow some kind of convention or as you said just close the PRs.

@SuperSandro2000
Copy link
Member

Can this be merged or not?

@andreisergiu98
Copy link
Member Author

Can this be merged or not?

Yes, I think all the work is done. Tested everything and it works fine.

tomberek
tomberek approved these changes Mar 25, 2021
View reviewed changes
pkgs/servers/sonarr/default.nix Show resolved Hide resolved
purcell
purcell approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@purcell purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, I think. Anyone with the appropriate permissions should feel free to merge this.

@tomberek tomberek merged commit 6144606 into NixOS:master Mar 25, 2021
@andreisergiu98 andreisergiu98 deleted the sonarr-update branch April 25, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@purcell purcell purcell approved these changes

@tomberek tomberek tomberek approved these changes

@fadenb fadenb Awaiting requested review from fadenb

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andreisergiu98 @tomberek @purcell @SuperSandro2000