New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.09] nixUnstable: 2.4pre20201205_a5d85d0 -> 2.4pre20210308_1c0e3e4, hydra-unstable: 2020-10-20 -> 2021-03-10 #115947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowdown-related changes look good to me, the breaking changes in 0.8.0 are as follows:
- Library API changes for functions that may fail due to allocation errors. This is what
nixUnstable
actually needs and fine since no other package currently depends on lowdown as a library - The
--nroff-hardwrap
option got removed. This is most likely a breakage fine to backport since it is reasonably obscure.
Not in Nixpkgs perhaps. For a simple package like lowdown, isn't it just as easy to duplicate it, so we have a |
Not a big deal especially on a maintenance branch, but would be nice to have the lowdown fixes in first so we don't have a known-broken commit in the history. |
Result of 5 packages marked as broken and skipped:
2 packages built successfully:Result of 6 packages built successfully:
|
(cherry picked from commit 182dc8b)
(cherry picked from commit cd62625)
(cherry picked from commit 8ee8dc8)
(cherry picked from commit 44f1a10)
Bug fixes for gemini and the difference engine, new lowdown-diff(1) man page: https://github.com/kristapsdz/lowdown/blob/e1ed0e1b11d152e6b8791c85f12496ff45b0a391/versions.xml#L1021-L1066 (cherry picked from commit b9f5c99)
hydra-unstable: 2020-10-20 -> 2021-03-10 (cherry picked from commit 9c5f8a2)
(cherry picked from commit d47ac89)
FWIW the lowdown library is pretty seldomly used where the lowdown utility and nix are the only known downstream users to the library's author afaik. But agreed, a |
82f018b
to
b7152e2
Compare
Done.
Done. |
Motivation for this change
Backport of #114786.
Also had to backport most recent lowdown bumps to get Nix compiling.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)