New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
btcpayserver: 1.0.6.8 -> 1.0.7.0 #115954
btcpayserver: 1.0.6.8 -> 1.0.7.0 #115954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things tested:
pkgs/applications/blockchains/nbxplorer./update.sh
and
pkgs/applications/blockchains/btcpayserver/update.sh
produce the same content as this PR.- The package builds and the nix-bitcoin VM test succeeds.
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
The following issues got detected with the above build packages.
btcpayserver:
warning: unused-argument
warning: unused-argument
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed |
@jonringer can we merge? |
do you mind squashing the two commits? otherwise LGTM |
4587a20
to
5c221a5
Compare
Squashed |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)The package builds and passes the nix-bitcoin VM test suite.
You can run the tests with this self-contained script.
@erikarvstedt