Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcpayserver: 1.0.6.8 -> 1.0.7.0 #115954

Merged
merged 1 commit into from Mar 25, 2021

Conversation

nixbitcoin
Copy link
Contributor

@nixbitcoin nixbitcoin commented Mar 11, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The package builds and passes the nix-bitcoin VM test suite.
You can run the tests with this self-contained script.

@erikarvstedt

Copy link
Member

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things tested:

  • pkgs/applications/blockchains/nbxplorer./update.sh and
    pkgs/applications/blockchains/btcpayserver/update.sh produce the same content as this PR.
  • The package builds and the nix-bitcoin VM test succeeds.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115954 run on x86_64-linux 1

1 package built:
  • btcpayserver

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

btcpayserver:

warning: unused-argument
Unused argument: writeScript.
Near pkgs/applications/blockchains/btcpayserver/default.nix:2:39:

  |
2 |   dotnetPackages, dotnetCorePackages, writeScript, bash
  |                                       ^

warning: unused-argument
Unused argument: bash.
Near pkgs/applications/blockchains/btcpayserver/default.nix:2:52:

  |
2 |   dotnetPackages, dotnetCorePackages, writeScript, bash
  |                                                    ^

Copy link
Member

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nixbitcoin
Copy link
Contributor Author

See #115954 (comment)

Fixed

@ofborg ofborg bot requested a review from erikarvstedt March 12, 2021 09:01
@nixbitcoin
Copy link
Contributor Author

@jonringer can we merge?

@jonringer
Copy link
Contributor

do you mind squashing the two commits? otherwise LGTM

@nixbitcoin
Copy link
Contributor Author

do you mind squashing the two commits? otherwise LGTM

Squashed

@ofborg ofborg bot requested a review from erikarvstedt March 22, 2021 11:54
@SuperSandro2000 SuperSandro2000 merged commit c42c182 into NixOS:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants