Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nerdctl: 0.7.0 -> 0.7.1 #115955

Merged
merged 1 commit into from Mar 11, 2021
Merged

nerdctl: 0.7.0 -> 0.7.1 #115955

merged 1 commit into from Mar 11, 2021

Conversation

06kellyjac
Copy link
Member

Motivation for this change

Bump nerdctl to 0.7.1

Other changes:
Extract bash completion
Move to using --version now it doesn't exit on containerd socket missing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
nerdctl: 0.7.0 -> 0.7.1
9a4843c 
Extract bash completion
Move to using --version now it doesn't exit on containerd socket missing
@ofborg ofborg bot requested a review from kalbasit March 11, 2021 15:56
@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 115955 run on x86_64-linux 1

1 package built:
  • nerdctl

@SuperSandro2000 SuperSandro2000 merged commit cf4c29a into NixOS:master Mar 11, 2021
@06kellyjac 06kellyjac deleted the nerdctl branch March 11, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@06kellyjac @SuperSandro2000