New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vala: 0.40.18 -> 0.40.25, 0.46.5 -> 0.46.13, 0.48.9 -> 0.48.14, init 0.50.4 #115967
Conversation
Result of 487 packages marked as broken and skipped:
5090 packages skipped due to time constraints:
47 packages built successfully:
Result of 530 packages marked as broken and skipped:
4099 packages skipped due to time constraints:
49 packages built successfully:
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 4 packages built:
The following issues got detected with the above build packages.
vala_0_40:
warning: EvalError |
Skimmed the changes and did not notice anything standing out:
|
We should have done this bump with the last GNOME release but I forgot about it and then I did not want to delay merging the update and then forgot about it again. Hopefully, with the next GNOME update, we will default to 0.52. Or shortly after. But major bumps are always hard, it is useful to have Hydra build the branch to see what breaks. |
That seems much more likely than me being able to do it, any of the PRs I've opened in the last several days take forever on what I have lying around, and I've had nixpkgs-review freeze on one of them after 2 days... not to mention not even having enough space for some of them 😅 |
Motivation for this change
Bumps for all releases that had them. 0.46 is regardless EOL.
Adds 0.50, but doesn't use it as default - I'm unclear but I think that bump would be a better fit for the next gnome release?
https://gitlab.gnome.org/GNOME/vala/raw/0.40.25/NEWS
https://gitlab.gnome.org/GNOME/vala/raw/0.46.13/NEWS
https://gitlab.gnome.org/GNOME/vala/raw/0.48.14/NEWS
https://gitlab.gnome.org/GNOME/vala/raw/0.50.4/NEWS
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)