libwebsockets: improve cross-compilation support #115995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building works on aarch64-multiplatform:
This patch disables building the test applications for libmosquitto in case you're cross-compiling. I don't think they're that important and this is the easiest fix for enabling cross-compilation.
If anyone cares enough about the test applications and wants to use them in a cross scenario, they could properly patch this. I'd assume that a patch would be the same for all versions, since I've seen this error at least on
3.1
and4.1
.Error log without this patch
Motivation for this change
libwebsockets is a dependency of mosquitto, and I tried cross-compiling mosquitto. It was easy to fix this dependency, so here we are.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Note that I haven't actually tried running this (yet), but at least it compiles now, which is a step in the right direction IMO.