Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lorri: 1.3.0 -> 1.3.1 #115997

Merged
merged 1 commit into from Mar 12, 2021
Merged

lorri: 1.3.0 -> 1.3.1 #115997

merged 1 commit into from Mar 12, 2021

Conversation

Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Mar 11, 2021

Fix lorri direnv triggering an unconditional rebuild every time it is run.

After fixing up the build loop people suddenly started noticing that
lorri was evaluating every time something ran lorri direnv, which
could potentially be every time the user switched between buffers in
the editor.

This is not the intended behaviour, since we should run an
unconditional build only the first time the project is added to the
watcher, and after rely on the watcher to notify us of any file
changes (or the user running lorri internal ping to force a
rebuild).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fix `lorri direnv` triggering an unconditional rebuild every time it is run.

After fixing up the build loop people suddenly started noticing that
lorri was evaluating every time something ran `lorri direnv`, which
could potentially be every time the user switched between buffers in
the editor.

This is not the intended behaviour, since we should run an
unconditional build only the first time the project is added to the
watcher, and after rely on the watcher to notify us of any file
changes (or the user running `lorri internal ping` to force a
rebuild).
@sternenseemann
Copy link
Member

@ofborg eval

@Profpatsch
Copy link
Member Author

didn’t even know there’s a @ofborg now

@sternenseemann
Copy link
Member

didn’t even know there’s a @ofborg now

graham only shows if summoned these days: NixOS/ofborg#549

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115997 run on x86_64-darwin 1

1 package built:
  • lorri

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

lorri:

warning: EvalError
Cannot evaluate attribute ‘lorri’ in ‘/nix/store/pcxrlj6r2s2g5ja7d8fbkxgcfmasy6i7-nixpkgs’.

@SuperSandro2000 SuperSandro2000 merged commit bb0d236 into NixOS:master Mar 12, 2021
@Profpatsch
Copy link
Member Author

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants