Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve zs-apc-spdu-ctl #116015

Closed
wants to merge 1 commit into from
Closed

Improve zs-apc-spdu-ctl #116015

wants to merge 1 commit into from

Conversation

fogti
Copy link
Contributor

@fogti fogti commented Mar 12, 2021 •
edited

Motivation for this change

Allow generating the config via programs.zs-apc-spdu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fogti
fogti commented Mar 12, 2021
View reviewed changes
nixos/modules/programs/zs-apc-spdu-ctl.nix Outdated
type = types.str;
default = "";
description = "Set the APC for this host";
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field should be required if cfg.defaultApc is not set (= "").

@fogti fogti force-pushed the zs-apc-spdu branch 2 times, most recently from 0b494c8 to 591bad7 Compare March 19, 2021 23:53
@fogti fogti requested a review from jonringer March 24, 2021 19:06
@fogti
nixos/programs.zs-apc-spdu: init
744fd84 
configuration example (fences are not part of the example):

```
apc 192.168.0.100

:host1
host 192.168.0.1
outlets 2

:host2
host 192.168.0.2
outlets 3 4
```
@stale
Copy link

stale bot commented Sep 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 26, 2021
@fogti fogti closed this by deleting the head repository Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fogti @SuperSandro2000 @jonringer