Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsviz: 0.9.2 -> 0.9.3 #116029

Merged
merged 1 commit into from Mar 21, 2021
Merged

dnsviz: 0.9.2 -> 0.9.3 #116029

merged 1 commit into from Mar 21, 2021

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Mar 12, 2021

Motivation for this change

Update to latest release (https://github.com/dnsviz/dnsviz/releases/tag/v0.9.3)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/cdphfhjb9b9fxim9l1if4gk6l2kv2jxq-dnsviz-0.9.2	  191017480
/nix/store/0r7nmrznz06x3qzc399pavbhda3dgzxv-dnsviz-0.9.3	  191018456

rmcgibbo
rmcgibbo approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed git diff, built with nixpkgs-review, binary runs fine.

@rmcgibbo rmcgibbo added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Mar 18, 2021
@SuperSandro2000 SuperSandro2000 merged commit c7b3fb9 into NixOS:master Mar 21, 2021
@jojosch jojosch deleted the dnsviz-0.9.3 branch March 22, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmcgibbo rmcgibbo rmcgibbo approved these changes

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jojosch @rmcgibbo @SuperSandro2000