Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 3.38.4 updates #116050

Merged
merged 19 commits into from Mar 15, 2021
Merged

Gnome 3.38.4 updates #116050

merged 19 commits into from Mar 15, 2021

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented Mar 12, 2021

Motivation for this change

Version bumps. Removes a few patches because they got merged and are present in these versions. Some of the C++ API packages switched to using meson dist for generating tarballs, so this is also reflected.

Versions based on https://ftp.fau.de/gnome/teams/releng/3.38.4/versions rather than latest, excluding the default vala bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

/rebase staging

@github-actions github-actions bot changed the base branch from master to staging March 12, 2021 22:48
@github-actions github-actions bot closed this Mar 12, 2021
@github-actions
Copy link
Contributor

Rebased, please reopen the pull request to restart CI

@amaxine

This comment has been minimized.

@amaxine
Copy link
Contributor Author

amaxine commented Mar 13, 2021

Those results are kinda useless, ran out of space towards the end and things failed to build because of that 🤦‍♀️

@jtojnar
Copy link
Contributor

jtojnar commented Mar 14, 2021

Yeah, it is often useful to split updates that cause mass rebuilds into a separate PR for easier building.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 14, 2021

635e5388ad1aa8cb0f020a373c4e032089ef0cd2: gnome3.yelp-xsl: 3.38.1 -> 3.38.3
(https://ftp.gnome.org/pub/GNOME/sources/yelp-xsl/3.38/yelp-xsl-3.38.2.news)
3.38.2
======
* Updated translations:
pt_BR (Juliano de Souza Camargo)

(https://ftp.gnome.org/pub/GNOME/sources/yelp-xsl/3.38/yelp-xsl-3.38.3.news)
3.38.3
======
* Updated translations:
  be    (Źmicier Turok)
  nb    (Kjartan Maraas)

2c5b24708e22408edbafad43625369e0a4c0309d: gnome3.yelp: 3.38.1 -> 3.38.3
(https://ftp.gnome.org/pub/GNOME/sources/yelp/3.38/yelp-3.38.2.news)
3.38.2
======
* Fix crash when reloading local document (Michael Catanzaro)

(https://ftp.gnome.org/pub/GNOME/sources/yelp/3.38/yelp-3.38.3.news)
3.38.3
======
* Updated translations:
  be    (Źmicier Turok)

f7f28dbb000092d6bf4a57684c7c41721f7905fc: gnome3.tracker-miners: 3.0.1 -> 3.0.4
“gnome3.tracker-miners” is an alias
1eb81e2254bc3fba077ed688563c864924f35cf3: gnome3.tracker: 3.0.1 -> 3.0.3
“gnome3.tracker” is an alias
9e203d1684f6ad925845aaf3a7fcf4a118ba38d9: gnome3.simple-scan: 3.38.1 -> 3.38.2
(https://ftp.gnome.org/pub/GNOME/sources/simple-scan/3.38/simple-scan-3.38.2.news)
Overview of changes in simple-scan 3.38.2
~~~~~~~~~~~~~~
Released: 2020-12-08

  * Add new text resolution 200 dpi [<a href="https://gitlab.gnome.org/GNOME/simple-scan/issues/175">#175</a>].
  * Fix crash when scanning on Lexmark MFP.
  * Display an error, when no documents found in the feeder during start scanning [<a href="https://gitlab.gnome.org/GNOME/simple-scan/issues/195">#195</a>].
  * Do not use is_inhibited() as it is not reliable, check the cookie value instead.
  * Updated translations.

5ce011dd77b6784c3343e452f313478a672a4208: gnome3.mutter: 3.38.2 -> 3.38.3
(https://ftp.gnome.org/pub/GNOME/sources/mutter/3.38/mutter-3.38.3.news)
3.38.3
======
* xwayland: Set xrandr primary output [Aleksandr; !1638]
* Disable CRTCs if there is no monitor [Kai-Heng; !1561]
* Fixed crashes [Olivier, Jonas; !1650]
* Misc. bug fixes [Marc-Antoine, Carlos; !1668, !1655]

Contributors:
  Jonas Ådahl, Kai-Heng Feng, Olivier Fourdan, Carlos Garnacho,
  Aleksandr Mezin, Marc-Antoine Perennou

Translators:
  Kjartan Maraas [nb], Juliano de Souza Camargo [pt], Florentina Mușat [ro]

f8efe4c800583e4d56727b2a5c4c1bdb3868c18c: gupnp: 1.2.0 -> 1.2.4
(https://ftp.gnome.org/pub/GNOME/sources/gupnp/1.2/gupnp-1.2.1.news)
1.2.1
=====
- Fix a deadlock when cancelling an action
- Do not call-back a cancelled action
- Fix public dependencies

Bugs fixed in this release:
 - https://gitlab.gnome.org/GNOME/gupnp/issues/7

All contributors to this release:
 - Jens Georg <mail@jensge.org>



(https://ftp.gnome.org/pub/GNOME/sources/gupnp/1.2/gupnp-1.2.2.news)
1.2.2
=====
- Fix macOS dylib versioning
- Fix endless loop on early notify
- Several documentation fixes
- Implement version-independent type registration in ResourceFactory
- Fix an issue with implementation of the depracted functions
- Fix an issue with including net/if.h and linux/if.h
- Add async introspection functions matching the usual GIO function pattern
- Go through main loop if introspection fails before the actual network request
- Bump required GLib version to 2.58

Bugs fixed in this release:
 - https://bugzilla.gnome.org/show_bug.cgi?id=764498
 - https://gitlab.gnome.org/GNOME/gupnp/issues/5
 - https://gitlab.gnome.org/GNOME/gupnp/issues/6
 - https://gitlab.gnome.org/GNOME/gupnp/issues/8

All contributors to this release:
 - Jens Georg <mail@jensge.org>
 - Fabrice Fontaine <fontaine.fabrice@gmail.com>
 - Tom Schoonjans <Tom.Schoonjans@diamond.ac.uk>



(https://ftp.gnome.org/pub/GNOME/sources/gupnp/1.2/gupnp-1.2.3.news)
1.2.3
=====
- Attention: Requires GSSDP 1.2.3!
- Always build the gupnp-binding-tool manpage
- Fix meson build on Windows
- Fix context creation for tests across different platforms
- Fix static linking issue caused by libguul subproject
- Add mitigations for CVE-2020-12695 (CallStranger)
- Implement UDA 2.0 April 17 2020 Addendum (Patial fix for CVE-2020-12695)

Bugs fixed in this release:
 - https://gitlab.gnome.org/GNOME/gupnp/issues/15
 - https://gitlab.gnome.org/GNOME/gupnp/issues/16

All contributors to this release:
 - Jens Georg <mail@jensge.org>
 - soiamsoNG <83182235@qq.com>
 - Peter Seiderer <ps.report@gmx.net>
 - Jan-Michael Brummer <jan.brummer@tabos.org>
 - Mart Raudsepp <leio@gentoo.org>



(https://ftp.gnome.org/pub/GNOME/sources/gupnp/1.2/gupnp-1.2.4.news)
1.2.4
=====
- Fix subscription check on V6 link-local addresses
- Add autofree function for GUPnPServiceProxyAction

All contributors to this release:
 - Jens Georg <mail@jensge.org>

8ac4fc7b1773a723b0042bec724f41eecf4ef099: pangomm: 2.42.1 -> 2.42.2
(https://ftp.gnome.org/pub/GNOME/sources/pangomm/2.42/pangomm-2.42.2.news)
2.42.2 (stable):

The tarball for 2.42.2 has been created with 'meson dist'.
If you build with Autotools from the tarball, please read the relevant
part of the README file.

Build:
* Use __declspec(dllexport) when building with Visual Studio
  (Chun-wei Fan) Merge request <a href="https://gitlab.gnome.org/GNOME/pangomm/merge_requests/14">!14</a>, <a href="https://gitlab.gnome.org/GNOME/pangomm/merge_requests/17">!17</a>
* Meson build: Avoid some recompilations
  (Kjell Ahlstedt)
* Meson build: Better error message if trying to build with
  maintainer-mode=false when true is necessary
  (Kjell Ahlstedt) Issue <a href="https://gitlab.gnome.org/GNOME/pangomm/issues/6">#6</a> (Rasmus Thomsen)
* Meson build: Set default value of the 'warnings' option to 'min'
  (Kjell Ahlstedt)
* Improve NMake support
  (Chun-wei Fan)
* Improve Visual Studio support
  (Chun-wei Fan) Merge request <a href="https://gitlab.gnome.org/GNOME/pangomm/merge_requests/14">!14</a>, <a href="https://gitlab.gnome.org/GNOME/pangomm/merge_requests/18">!18</a>
* docs/reference/: Update for Doxygen >= 1.8.16
  (Kjell Ahlstedt)
* Meson build: Fix versioning on macOS
  (Kjell Ahlstedt) Pull request libsigcplusplus#65 (Tom Schoonjans)

c7afa44badb49235fdee18e5a64f65e9dd25aef9: gtkmm: 3.24.2 -> 3.24.3
Attribute “gtkmm” does not exist
6f54e71: gnome3.gnome-shell: 3.38.2 -> 3.38.3
(https://ftp.gnome.org/pub/GNOME/sources/gnome-shell/3.38/gnome-shell-3.38.3.news)
3.38.3
======
* Fix disappearing app grid [Georges; !1532]
* Fix screenshots of unredirected fullscreen windows on X11
[Jonas, LuK1337; !1536, !1552]
* Fix storing VPN secrets [Sebastian; !1535]
* Fix glitches in overview transitions [Jonas, Ivan; !1564, !1550]
* Improve login screen accessibility [Mike; !1567]
* Fixed crashes [Jonas; !1540]
* Misc. bug fixes and cleanups [Florian, Jonas, Ivan;
!1530, !1531, !1541, !1548, !1551]

Contributors:
  Jonas Ådahl, Mike Gerow, Sebastian Keller, LuK1337, Ivan Molodetskikh,
  Florian Müllner, Georges Basile Stavracas Neto

Translators:
  Florentina Mușat [ro], Kjartan Maraas [nb]

93151f8: gnome3.gnome-maps: 3.38.2 -> 3.38.4
(https://ftp.gnome.org/pub/GNOME/sources/gnome-maps/3.38/gnome-maps-3.38.3.news)
3.38.3 - Jan 9, 2021
=========================

Changes since 3.38.2
 - Fix a bug where place details gets lost after searching again for the same
   place

Added/updated/fixed translations
 - Norwegian Bokmål

All contributors to this release
Kjartan Maraas <kmaraas@gnome.org>
Marcus Lundblad <ml@update.uu.se>



(https://ftp.gnome.org/pub/GNOME/sources/gnome-maps/3.38/gnome-maps-3.38.4.news)
3.38.4 - Feb 12, 2021
=========================

Changes since 3.38.3
 - Fix a bug resulting in writing a broken last view position on exit in
   some circumstances
 - Fix a bug preventing wrapping around at the date line with dark tiles
 - Fix a bug causing hanging in cases when dragging around route markers

Added/updated/fixed translations
 - Norwegian Bokmål

All contributors to this release
Kjartan Maraas <kmaraas@gnome.org>
Marcus Lundblad <ml@update.uu.se>

44c05e6: gnome3.gnome-initial-setup: 3.38.2 -> 3.38.4
(https://ftp.gnome.org/pub/GNOME/sources/gnome-initial-setup/3.38/gnome-initial-setup-3.38.3.news)
3.38.3
------

* Translation updates:
 - Norwegian Bokmål
 - Romanian



(https://ftp.gnome.org/pub/GNOME/sources/gnome-initial-setup/3.38/gnome-initial-setup-3.38.4.news)
3.38.4
------

* Fix a small memory leak in timezone page. (<a href="https://gitlab.gnome.org/GNOME/gnome-initial-setup/issues/119">#119</a>)

487eede: gnome3.gnome-disk-utility: 3.38.1 -> 3.38.2
(https://ftp.gnome.org/pub/GNOME/sources/gnome-disk-utility/3.38/gnome-disk-utility-3.38.2.news)
3.38.2 - February 11, 2020
==========================

Kai Lüke:
 * Ignore the --xid option when formatting from Nautilus
   (this aligns the behavior under X11 with that on Wayland)

Updated translations:
 * Kjartan Maraas (nb), Źmicier Turok (be)

588505d: gnome3.gnome-desktop: 3.38.2 -> 3.38.4
(https://ftp.gnome.org/pub/GNOME/sources/gnome-desktop/3.38/gnome-desktop-3.38.3.news)
==============
Version 3.38.3
==============

Translation updates



(https://ftp.gnome.org/pub/GNOME/sources/gnome-desktop/3.38/gnome-desktop-3.38.4.news)
==============
Version 3.38.4
==============

Translation updates

50d6fae: gnome3.gnome-control-center: 3.38.1 -> 3.38.4
(https://ftp.gnome.org/pub/GNOME/sources/gnome-control-center/3.38/gnome-control-center-3.38.2.news)
================
Version 3.38.2
================

- Updated translations

Applications:
- Fix NULL hash table being unreffed.

Keyboard:
- fix gtk_widget_get_can_default assertion error.

Network:
- Correctly detect when ethernet devices are hotplugged.

Printers:
- Make printers panel have a smaller minimum width.
- Fix leak of printer name in callbacks.

Sharing:
- Disable Tracker 3.

Sound:
- Update libgvc to add support for recent UCM related changes in ALSA and
  PulseAudio.

Users:
- Fix free of const string.

Wacom:
- Fix a critical warning if loading a cursor fails.



(https://ftp.gnome.org/pub/GNOME/sources/gnome-control-center/3.38/gnome-control-center-3.38.3.news)
================
Version 3.38.3
================

- Updated translations

Display:
- Fix crash when unable to get display configuration.

Network:
- Fix smal leak getting WiFi secrets.

Printers:
- Fix small leaks in new printer dialog.

User Accounts:
- Fix crash showing error in fingerprint dialog.



(https://ftp.gnome.org/pub/GNOME/sources/gnome-control-center/3.38/gnome-control-center-3.38.4.news)
================
Version 3.38.4
================

- Updated translations

User Accounts:
- Properly handle claiming errors if we're already claiming.
- Always call EnrollStop on enrollment complete.

16845e9: vte: 0.62.1 -> 0.62.2
No file describing changes found for group in cluster with “0.62.2”
09aaf50: glibmm: 2.64.2 -> 2.64.5
(https://ftp.gnome.org/pub/GNOME/sources/glibmm/2.64/glibmm-2.64.4.news)
2.64.4: (stable):

The tarball for 2.64.4 has been created with 'meson dist'.
If you build with Autotools from the tarball, please read the relevant
part of the README file.

Glib:
* PropertyProxyConnectionNode::connect_changed():
  Fix using without property name
  (Daniel Boles) Issue <a href="https://gitlab.gnome.org/GNOME/glibmm/issues/74">#74</a> (wswfc), merge request <a href="https://gitlab.gnome.org/GNOME/glibmm/merge_requests/35">!35</a>

gmmproc:
* Add optional decl_prefix parameter to _WRAP_GERROR and _WRAP_ENUM
  Used for adding GLIBMM_API or similar for MS Visual C++
  (Chun-wei Fan) Merge request <a href="https://gitlab.gnome.org/GNOME/glibmm/merge_requests/31">!31</a>
* Allow decorating comparison operators (for Visual Studio builds)
  (Chun-wei Fan) Merge request <a href="https://gitlab.gnome.org/GNOME/glibmm/merge_requests/34">!34</a>
* _CLASS_BOXEDTYPE, _CLASS_OPAQUE_COPYABLE: Fix move assignment
  (Kjell Ahlstedt) Issue <a href="https://gitlab.gnome.org/GNOME/glibmm/issues/76">#76</a> (misos1)
* Decorate private generated classes with __declspec when building
  with Visual Studio
  (Chun-wei Fan) Merge request <a href="https://gitlab.gnome.org/GNOME/glibmm/merge_requests/40">!40</a>, <a href="https://gitlab.gnome.org/GNOME/glibmm/merge_requests/42">!42</a>
* generate_wrap_init.pl.in: Use g_type_ensure(SomeClass::get_type())
  to ensure that get_type() is called
  (Kjell Ahlstedt)

Build:
* Use __declspec(dllexport) consistently when building glibmm with
  Visual Studio
  (Chun-wei Fan) Merge request <a href="https://gitlab.gnome.org/GNOME/glibmm/merge_requests/31">!31</a>
* Meson build: Set default value of the 'warnings' option to 'min'
  (Kjell Ahlstedt)
* Improve NMake support
  (Chun-wei Fan)
* Improve Visual Studio support
  (Chun-wei Fan) Merge request <a href="https://gitlab.gnome.org/GNOME/glibmm/merge_requests/36">!36</a>
* docs/reference/: Update for Doxygen >= 1.8.16
  (Kjell Ahlstedt)
* Meson build: Fix versioning on macOS
  (Kjell Ahlstedt) Pull request libsigcplusplus#65 (Tom Schoonjans)

Documentation:
* Glib::BalancedTree docs: Recommend std::map or std::unordered_map
  (Kjell Ahlstedt)
* Meson build: Add missing Glib::Value and Variant documentation
  (Kjell Ahlstedt)




(https://ftp.gnome.org/pub/GNOME/sources/glibmm/2.64/glibmm-2.64.5.news)
2.64.5: (stable):

The tarball for 2.64.5 has been created with 'meson dist'.
If you build with Autotools from the tarball, please read the relevant
part of the README file.

gmmproc:
* Fix compatibility with gtkmm 3.24.2
  (Kjell Ahlstedt) Issue <a href="https://gitlab.gnome.org/GNOME/glibmm/issues/82">#82</a> (Michael Catanzaro)

Build:
* Meson build: Fix Cocoa (macOS) detection
  (Tom Schoonjans) Merge request <a href="https://gitlab.gnome.org/GNOME/glibmm/merge_requests/43">!43</a>

2f17a4c: gnome3.eog: 3.38.1 -> 3.38.2
(https://ftp.gnome.org/pub/GNOME/sources/eog/3.38/eog-3.38.2.news)
Version 3.38.2
--------------

Bug fixes:

 <a href="https://gitlab.gnome.org/GNOME/eog/issues/169">#169</a>, Warning about overwriting GError when unlinking a directory
       while viewing (Felix Riemann)
 <a href="https://gitlab.gnome.org/GNOME/eog/issues/172">#172</a>, Update appdata screenshot (Evi Kavrochorianou)

New and updated translations:

- Kjartan Maraas [nb]

New and updated manual translations

- Miquel-Àngel Burgos i Fradeja [ca]

64ecd41: gnome3.dconf-editor: 3.38.0 -> 3.38.2, cleanup
Unable to recognize updated package.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 14, 2021

Ugh, I really need to add some post-processing code to https://github.com/jtojnar/what-changed so that GitHub renders the changelog snapshots better.

The changelogs that I saw above look good.

  • Suspiciously looking “Disable Tracker 3.” in g-c-c turned out to be benign: g-c-c!865.

The following commits messages need to be adjusted:

  • f7f28db: gnome3.tracker-miners: 3.0.1 -> 3.0.4
    “gnome3.tracker-miners” is an alias
  • 1eb81e2: gnome3.tracker: 3.0.1 -> 3.0.3
    “gnome3.tracker” is an alias
  • c7afa44: gtkmm: 3.24.2 -> 3.24.3
    Attribute “gtkmm” does not exist

Vte does not have changelogs so I checked https://gitlab.gnome.org/GNOME/vte/compare/0.62.1...0.62.2 for 16845e9: vte: 0.62.1 -> 0.62.2
It looks okay except for this terrible workaround for occassional crash. I will be reverting that on my machines.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 14, 2021

Those remaining changelogs look okay too:

bf7f622: tracker-miners: 3.0.1 -> 3.0.4
(https://ftp.gnome.org/pub/GNOME/sources/tracker-miners/3.0/tracker-miners-3.0.3.news)
NEW in 3.0.3 - 2020-12-09
=========================
* Allow newstatat/statat64 syscalls
* Brown paper bag release

NEW in 3.0.2 - 2020-12-08
=========================
  * Fix sched test under non glibc platforms
  * Refcount fixes
  * Avoid the fluiddec gstreamer plugin
  * Ensure to avoid non-native files in tracker-extract-3
  * CI fixes

Translations: pt



(https://ftp.gnome.org/pub/GNOME/sources/tracker-miners/3.0/tracker-miners-3.0.4.news)
NEW in 3.0.4 - 2021-01-10
=========================
  * Improve time_t interpretation for negative timestamps
  * Fix "tracker3 search --folders"
  * Fix crasher after tracker-miner-fs SPARQL failures
  * CI fixes

Translations: ro

93221ce: tracker: 3.0.1 -> 3.0.3
(https://ftp.gnome.org/pub/GNOME/sources/tracker/3.0/tracker-3.0.2.news)
NEW in 3.0.2 - 2020-12-08
=========================
* Update some wording in website
* Fix initialization issues in portal
* Improve turtle parser
* Improve checks for dates in the far past/future
* Cleanup meson build options
* Fix invalid reads
* Make UPDATE parser tree processing iterative rather
than recursive
* Fix errors in tracker:uri-is-parent
* Protect harder against invalid database state
* Introspection annotation fixes
* Improve thread safety of internal ontology objects
* Add missing element to gir file

(https://ftp.gnome.org/pub/GNOME/sources/tracker/3.0/tracker-3.0.3.news)
NEW in 3.0.3 - 2021-01-10
=========================
  * Avoid FTS5 table inconsistency with SQLite >= 3.34.0
  * Fix out parameter in VAPI/Vala files

Translations: ro

4e94d2d: gtkmm3: 3.24.2 -> 3.24.3
(https://ftp.gnome.org/pub/GNOME/sources/gtkmm/3.24/gtkmm-3.24.3.news)
3.24.3 (stable):

The tarball for 3.24.3 has been created with 'meson dist'.
If you build with Autotools from the tarball, please read the relevant
part of the README file.

Gtk:
* Actionable::get_action_target_value(): Fix ref count
  (Kjell Ahlstedt)

Documentation:
* Improve the documentation of Gtk::Application::add_window()
  and Gtk::Window::set_application()
  (Kjell Ahlstedt) Issue <a href="https://gitlab.gnome.org/GNOME/gtkmm/issues/56">#56</a> (Daniel Boles)
* Gtk::Button::set_image(): Fix the documentation
  (Daniel Boles) Issue <a href="https://gitlab.gnome.org/GNOME/gtkmm/issues/58">#58</a>, merge request <a href="https://gitlab.gnome.org/GNOME/gtkmm/merge_requests/22">!22</a>
* Gtk::TreeView::append_column(): Add code example
  (Pavlo Solntsev) Merge request <a href="https://gitlab.gnome.org/GNOME/gtkmm/merge_requests/21">!21</a>
* README: Add instructions for building gtkmm
  (Kjell Ahlstedt)
* Explain key values
  (Kjell Ahlstedt) Issue <a href="https://gitlab.gnome.org/GNOME/gtkmm/issues/6">#6</a> (Mark Vender)

Demos:
* Don't use C++14 auto deduction
  (Daniel Boles)
* Update the GLArea demo (similar to updates in gtk+)
  (Kjell Ahlstedt)
* GLArea demo: Fix a crash
  (Kjell Ahlstedt) Issue <a href="https://gitlab.gnome.org/GNOME/gtkmm/issues/63">#63</a> (Gerlof Fokkema)

Tests:
* Builder test: Test derived props declared in C++
  (Daniel Boles) Merge request <a href="https://gitlab.gnome.org/GNOME/gtkmm/merge_requests/23">!23</a>

Build:
* Improve NMake support
  (Chun-wei Fan)
* Fix Autotools build with X11 backend disabled (--enable-x11-backend=no)
  (Kjell Ahlstedt)
* Use __declspec(dllexport) when building with Visual Studio
  (Chun-wei Fan) Merge request <a href="https://gitlab.gnome.org/GNOME/gtkmm/merge_requests/25">!25</a>
* Add support for building gtkmm with Meson
  (Chun-wei Fan, Kjell Ahlstedt) Merge request <a href="https://gitlab.gnome.org/GNOME/gtkmm/merge_requests/24">!24</a>, <a href="https://gitlab.gnome.org/GNOME/gtkmm/merge_requests/26">!26</a>
* docs/reference/: Update for Doxygen >= 1.8.16
  (Kjell Ahlstedt)

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Mar 14, 2021
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 14, 2021

Cleaned all this up. I've been avoiding doing cleanup, since I was told in a PR review it's wrong to do together with updates 🤷‍♀️

Obviously, opinions will differ on what is okay but, IMO, it is only wrong when it makes reviewing hard by obscuring changes. In this case both changes are trivial and entangled together so I would consider that fair game. If this was a more invasive change (e.g. splitting inputs so that there is one dependency per line), I would probably do that in a separate commit but still in the same PR.

@jtojnar jtojnar merged commit 0a35ec9 into NixOS:staging Mar 15, 2021
@amaxine amaxine deleted the gnome_3.38.4 branch July 19, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants