New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnome 3.38.4 updates #116050
Gnome 3.38.4 updates #116050
Conversation
/rebase staging |
Rebased, please reopen the pull request to restart CI |
This comment has been minimized.
This comment has been minimized.
Those results are kinda useless, ran out of space towards the end and things failed to build because of that 🤦♀️ |
Yeah, it is often useful to split updates that cause mass rebuilds into a separate PR for easier building. |
635e5388ad1aa8cb0f020a373c4e032089ef0cd2: gnome3.yelp-xsl: 3.38.1 -> 3.38.3
2c5b24708e22408edbafad43625369e0a4c0309d: gnome3.yelp: 3.38.1 -> 3.38.3
f7f28dbb000092d6bf4a57684c7c41721f7905fc: gnome3.tracker-miners: 3.0.1 -> 3.0.4
5ce011dd77b6784c3343e452f313478a672a4208: gnome3.mutter: 3.38.2 -> 3.38.3
f8efe4c800583e4d56727b2a5c4c1bdb3868c18c: gupnp: 1.2.0 -> 1.2.4
8ac4fc7b1773a723b0042bec724f41eecf4ef099: pangomm: 2.42.1 -> 2.42.2
c7afa44badb49235fdee18e5a64f65e9dd25aef9: gtkmm: 3.24.2 -> 3.24.3
93151f8: gnome3.gnome-maps: 3.38.2 -> 3.38.4
44c05e6: gnome3.gnome-initial-setup: 3.38.2 -> 3.38.4
487eede: gnome3.gnome-disk-utility: 3.38.1 -> 3.38.2
588505d: gnome3.gnome-desktop: 3.38.2 -> 3.38.4
50d6fae: gnome3.gnome-control-center: 3.38.1 -> 3.38.4
16845e9: vte: 0.62.1 -> 0.62.2
2f17a4c: gnome3.eog: 3.38.1 -> 3.38.2
64ecd41: gnome3.dconf-editor: 3.38.0 -> 3.38.2, cleanup |
Ugh, I really need to add some post-processing code to https://github.com/jtojnar/what-changed so that GitHub renders the changelog snapshots better. The changelogs that I saw above look good.
The following commits messages need to be adjusted:
Vte does not have changelogs so I checked https://gitlab.gnome.org/GNOME/vte/compare/0.62.1...0.62.2 for 16845e9: vte: 0.62.1 -> 0.62.2 |
both patches are merged upstream meson.build changes no longer required as upstream does it too
Those remaining changelogs look okay too: bf7f622: tracker-miners: 3.0.1 -> 3.0.4
93221ce: tracker: 3.0.1 -> 3.0.3
4e94d2d: gtkmm3: 3.24.2 -> 3.24.3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks.
Obviously, opinions will differ on what is okay but, IMO, it is only wrong when it makes reviewing hard by obscuring changes. In this case both changes are trivial and entangled together so I would consider that fair game. If this was a more invasive change (e.g. splitting inputs so that there is one dependency per line), I would probably do that in a separate commit but still in the same PR. |
Motivation for this change
Version bumps. Removes a few patches because they got merged and are present in these versions. Some of the C++ API packages switched to using
meson dist
for generating tarballs, so this is also reflected.Versions based on https://ftp.fau.de/gnome/teams/releng/3.38.4/versions rather than latest, excluding the default vala bump.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)