system76-firmware: remove aarch64-linux support #116108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
approved these changes
Mar 12, 2021
| license = lib.licenses.gpl3; | ||
| maintainers = [ lib.maintainers.shlevy ]; | ||
| platforms = lib.platforms.linux; | ||
| license = licenses.gpl3; |
There was a problem hiding this comment.
Not sure. Don't have much experience with licenses. Here it is:
https://github.com/pop-os/system76-firmware/blob/master/LICENSE
What do you think?
There was a problem hiding this comment.
It does not mention later anywhere so it is gpl3Only.
There was a problem hiding this comment.
I have changed license to gpl3Only.
|
I think it was just set to linux without thinking about the arch to much. |
shlevy
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package "system76-firmware" build in aarch64 is failing:
https://hydra.nixos.org/build/138891792#tabs-summary
https://hydra.nixos.org/build/138891792/nixlog/2
But it doesn't make sense on ARM because it's for installing firmware updates on System76 machines which are x86/amd64.
As it is broken now in aarch64 and cluttering build pipeline seems desirable to limit it to i386/amd64.
A PR with a fix for aarch64 can reverse this.
Tried to reach upstream on IRC but I could only talk to community member buzel that agreed on this approach.
Took the opportunity for a minor clean-up.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)