Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyatv: 0.7.6 -> 0.7.7 #116267

Merged
merged 2 commits into from Mar 16, 2021
Merged

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Mar 14, 2021

Motivation for this change

Update to latest upstream release 0.7.7

Change log: https://github.com/postlund/pyatv/blob/master/CHANGES.md#077-2021-03-12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 14, 2021

Result of nixpkgs-review pr 116267 at 6a9ad9f7 run on aarch64-linux 1

2 packages built successfully:
1 suggestion:
  • warning: unused-argument

    Unused argument: asynctest.
    Near pkgs/development/python-modules/pyatv/default.nix:4:3:

      |
    4 | , asynctest
      |   ^
    

Result of nixpkgs-review pr 116267 at 6a9ad9f7 run on x86_64-linux 1

2 packages built successfully:
1 suggestion:
  • warning: unused-argument

    Unused argument: asynctest.
    Near pkgs/development/python-modules/pyatv/default.nix:4:3:

      |
    4 | , asynctest
      |   ^
    

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116267 run on x86_64-linux 1

2 packages built:
  • python38Packages.pyatv
  • python39Packages.pyatv

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.pyatv:

warning: unused-argument
Unused argument: asynctest.
Near pkgs/development/python-modules/pyatv/default.nix:4:3:

  |
4 | , asynctest
  |   ^

@fabaff
Copy link
Member Author

fabaff commented Mar 15, 2021

Result of nixpkgs-review pr 116267 run on x86_64-linux 1

2 packages built:
  • python38Packages.pyatv
  • python39Packages.pyatv

@SuperSandro2000 SuperSandro2000 merged commit ccb87c7 into NixOS:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants