Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/hidpi: add xserver dpi #116290

Merged
merged 1 commit into from Aug 12, 2021
Merged

nixos/hidpi: add xserver dpi #116290

merged 1 commit into from Aug 12, 2021

Conversation

aaronjanse
Copy link
Member

Motivation for this change

Addresses a TODO comment. More importantly, this should improve NixOS's out-of-the-box experience.

Some additions we may want to consider:

{
  services.xserver.displayManager.sessionCommands = ''
    ${pkgs.xorg.xrdb}/bin/xrdb -merge <<EOF
      Xcursor.theme: Vanilla-DMZ
      Xcursor.size: 32
    EOF
  '';
  environment.variables = {
    GDK_SCALE = "1.5";
    GDK_DPI_SCALE = "0.75";
    QT_AUTO_SCREEN_SCALE_FACTOR = "1";
  };
}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mrkkrp
Copy link
Member

mrkkrp commented Nov 29, 2021

FYI, this doesn't really improve NixOS out-of-the-box experience. I just spent 1 hour figuring out why all UI widgets suddenly became oversized on my external screen after an update. The solution? Remove incorrect hardcoded DPI setting:

  services.xserver.dpi = null;

@Artturin
Copy link
Member

Artturin commented Nov 29, 2021

i'll revert it. and instead add it as a commented line to the configuration.nix that nixos-generate-config creates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants