Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-network_2_6_3_1: disable test suite #116428

Merged

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Mar 15, 2021

Motivation for this change

The package is missing required files for the test suite. This fixes the
following build error:

  Building test suite 'regression' for network-2.6.3.1..
  [1 of 1] Compiling Main             ( tests/Regression.hs,
dist/build/regression/regression-tmp/Main.o )

  tests/Regression.hs:12:1: error:
      Could not find module ‘Regression.Issue215’
      Use -v (or `:set -v` in ghci) to see a list of the files searched
for.
     |
  12 | import qualified Regression.Issue215 as Issue215
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Shouldn't this go into haskell-updates?

@bennofs
Copy link
Contributor Author

bennofs commented Mar 15, 2021

@SuperSandro2000 ah idk, what's the policy for haskell-updates? This is not an update and has negligible rebuild amounts.

@cdepillabout
Copy link
Member

/rebase haskell-updates

The package is missing required files for the test suite. This fixes the
following build error:

```
  Building test suite 'regression' for network-2.6.3.1..
  [1 of 1] Compiling Main             ( tests/Regression.hs,
dist/build/regression/regression-tmp/Main.o )

  tests/Regression.hs:12:1: error:
      Could not find module ‘Regression.Issue215’
      Use -v (or `:set -v` in ghci) to see a list of the files searched
for.
     |
  12 | import qualified Regression.Issue215 as Issue215
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
@github-actions github-actions bot changed the base branch from master to haskell-updates March 16, 2021 01:01
@github-actions
Copy link
Contributor

Rebased, please reopen the pull request to restart CI

@github-actions github-actions bot closed this Mar 16, 2021
@cdepillabout cdepillabout reopened this Mar 16, 2021
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.network_2_6_3_1

@cdepillabout
Copy link
Member

@bennofs Thanks for sending this in.

In general we try to merge all Haskell-related things to the haskell-updates branch (partly just to make sure there are no merge conflicts when merging haskell-updates into master).

Luckily now we have actions rebasing, so I just rebased this onto haskell-updates.

This LGTM

@cdepillabout cdepillabout merged commit e93c109 into NixOS:haskell-updates Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants