Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mpv: 0.4.7 -> 0.5.2 #116462

Merged
merged 2 commits into from Mar 16, 2021

Conversation

sumnerevans
Copy link
Member

@sumnerevans sumnerevans commented Mar 15, 2021

Motivation for this change

Package upgrade.

Also clarifying license according to what is here: https://pypi.org/project/python-mpv/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 15, 2021

Result of nixpkgs-review pr 116462 at c6e28f0 run on aarch64-linux 1

1 package skipped due to time constraints:
  • plex-mpv-shim
4 packages built successfully:
2 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/mpv/default.nix:28:3:

       |
    28 |   meta = with lib; {
       |   ^
    
  • warning: unclear-gpl

    agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

    Near pkgs/development/python-modules/mpv/default.nix:31:5:

       |
    31 |     license = licenses.agpl3;
       |     ^
    

Result of nixpkgs-review pr 116462 at c6e28f0 run on x86_64-linux 1

1 package skipped due to time constraints:
  • plex-mpv-shim
4 packages built successfully:
2 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/mpv/default.nix:28:3:

       |
    28 |   meta = with lib; {
       |   ^
    
  • warning: unclear-gpl

    agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

    Near pkgs/development/python-modules/mpv/default.nix:31:5:

       |
    31 |     license = licenses.agpl3;
       |     ^
    

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116462 run on x86_64-linux 1

5 packages built:
  • jellyfin-mpv-shim
  • plex-mpv-shim
  • python38Packages.mpv
  • python39Packages.mpv
  • sublime-music

@SuperSandro2000 SuperSandro2000 merged commit 73be16c into NixOS:master Mar 16, 2021
sumnerevans added a commit to sumnerevans/home-manager-config that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants