Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.54.2 -> 1.54.3 #116481

Merged
merged 1 commit into from Mar 25, 2021
Merged

vscode: 1.54.2 -> 1.54.3 #116481

merged 1 commit into from Mar 25, 2021

Conversation

samuela
Copy link
Member

@samuela samuela commented Mar 15, 2021

Motivation for this change

Upgrades vscode from 1.54.2 to 1.54.3

This PR was automatically generated by nixpkgs-upkeep.

  • CI workflow that created this PR.
  • Internal tag: 0dc35d057411f6417c5cb5ddb37faa48.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from eadwu and Synthetica9 March 15, 2021 22:42
@samuela samuela mentioned this pull request Mar 15, 2021
Closed
10 tasks
@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 15, 2021 •
edited

Result of nixpkgs-review pr 116481 at 514a6f5 run on aarch64-linux 1

2 packages built successfully:
  • vscode
  • vscode-with-extensions

Result of nixpkgs-review pr 116481 at 514a6f5 run on x86_64-linux 1

2 packages built successfully:
  • vscode
  • vscode-with-extensions

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/360

@SuperSandro2000 SuperSandro2000 merged commit b4cceda into NixOS:master Mar 25, 2021
@samuela samuela deleted the upkeep-bot/vscode-1.54.3-1615847575 branch March 25, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eadwu eadwu Awaiting requested review from eadwu

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samuela @r-rmcgibbo @nixos-discourse @SuperSandro2000