Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.gradient-utils: fix build, python3Packages.gradient: allow later websocket-client releases #116511

Merged
merged 2 commits into from Mar 17, 2021
Merged

python3Packages.gradient-utils: fix build, python3Packages.gradient: allow later websocket-client releases #116511

merged 2 commits into from Mar 17, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Mar 16, 2021

Motivation for this change

Fix build

Issue came up in #116265

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Mar 16, 2021

Result of nixpkgs-review pr 116511 run on x86_64-linux 1

2 packages built:
  • python38Packages.gradient
  • python38Packages.gradient-utils

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 116511 at d1a77e5 run on aarch64-linux 1

2 packages built successfully:

@rmcgibbo rmcgibbo mentioned this pull request Mar 16, 2021
Merged
10 tasks
@NeQuissimus NeQuissimus merged commit 8ef3e44 into NixOS:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@freezeboy freezeboy Awaiting requested review from freezeboy

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @r-rmcgibbo @NeQuissimus