qtwebengine: use pure sandbox lib #116528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -190,6 +186,7 @@ qtModule { | |||
|
|
|||
| buildInputs = optionals stdenv.isDarwin (with darwin; [ | |||
There was a problem hiding this comment.
darwin shouldn't be used as an input.
There was a problem hiding this comment.
Noted, but it's a big refactoring, better come in a separate PR.
21 tasks
veprbl
reviewed
Mar 19, 2021
| cp "${darwin-stubs}/usr/lib/libsandbox.1.tbd" $out/lib | ||
| ln -s libsandbox.1.tbd $out/lib/libsandbox.tbd | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
Just a note:
cc #67166
This may could use (currently unimplemented) __propagatedImpureHostDeps = [ "/usr/bin/libsandbox.1.dylib" ]
veprbl
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Improve purity and fix the build on Big Sur, see #116358 and #98541 (comment)
I don't know if this package should be called
sandboxorlibsandbox, but the other libraries didn't have thelibprefix.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)