Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sogo: python2 -> python3 #116538

Merged
merged 1 commit into from Mar 16, 2021
Merged

sogo: python2 -> python3 #116538

merged 1 commit into from Mar 16, 2021

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Mar 16, 2021

Motivation for this change

Python 2 is deprecated. Debian does the same https://sources.debian.org/patches/sogo/5.0.1-4/python3.patch/

None of the python code in Tests/ seems compatible with python3, but apparently we don't run the test suite.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested a review from dasJ March 16, 2021 16:48
@ajs124 ajs124 added this to Needs review in Python 2 deprecation Mar 16, 2021
@ofborg ofborg bot requested a review from dasJ March 16, 2021 16:57
@ajs124 ajs124 merged commit 31ced62 into NixOS:master Mar 16, 2021
Python 2 deprecation automation moved this from Needs review to Done Mar 16, 2021
@ajs124 ajs124 deleted the sogo-py3 branch March 16, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants