Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

juniper: init at 2.3.0 #116576

Merged
merged 2 commits into from Apr 12, 2021
Merged

juniper: init at 2.3.0 #116576

merged 2 commits into from Apr 12, 2021

Conversation

wunderbrick
Copy link
Contributor

Motivation for this change

Juniper is a functional reactive programming language for programming Arduino.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 17, 2021 •
edited

Result of nixpkgs-review pr 116576 at 2d2896ef run on x86_64-linux 1

1 package built successfully:
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/compilers/juniper/default.nix:17:3:

       |
17 |   installPhase = ''
   |   ^
  • warning: unused-argument

    Unused argument: writeTextFile.
    Near pkgs/development/compilers/juniper/default.nix:1:16:

      |
1 | { lib, stdenv, writeTextFile, fetchzip, mono }:
  |                ^

Result of nixpkgs-review pr 116576 at 2d2896ef run on aarch64-linux 1

1 package built successfully:
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/compilers/juniper/default.nix:17:3:

       |
17 |   installPhase = ''
   |   ^
  • warning: unused-argument

    Unused argument: writeTextFile.
    Near pkgs/development/compilers/juniper/default.nix:1:16:

      |
1 | { lib, stdenv, writeTextFile, fetchzip, mono }:
  |                ^

SuperSandro2000
SuperSandro2000 reviewed Mar 17, 2021
View reviewed changes
maintainers/maintainer-list.nix Outdated
@@ -10888,4 +10888,10 @@
github = "zupo";
githubId = 311580;
};
wunderbrick = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this into a separate commit with the message maintainers: add wunderbrick.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really should add to the template that this needs to be sorted alphabetically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really should add to the template that this needs to be sorted alphabetically.

Would you like me to change the maintainers so mine is in alphabetical order? The last few entries are in no particular order. Please tell me what specifically, if anything, I need to do to get this package merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like me to change the maintainers so mine is in alphabetical order?

yes please.

The last few entries are in no particular order.

thats by accident. They should be sorted, too.

pkgs/development/compilers/juniper/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/juniper/default.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please drop the commits you added by accident.

pkgs/development/compilers/juniper/default.nix Outdated Show resolved Hide resolved
@wunderbrick wunderbrick reopened this Mar 31, 2021
SuperSandro2000
SuperSandro2000 requested changes Mar 31, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all juniper related commits together.

@wunderbrick wunderbrick force-pushed the juniper branch 3 times, most recently from 542a5c6 to bffb883 Compare March 31, 2021 16:54
@wunderbrick
Copy link
Contributor Author

Please squash all juniper related commits together.

Done, thanks.

@SuperSandro2000
Copy link
Member

Other than that the package is good to go. Sorry for the delays but to many PRs to look at.

@SuperSandro2000 SuperSandro2000 merged commit 36d6015 into NixOS:master Apr 12, 2021
@wunderbrick wunderbrick deleted the juniper branch April 12, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir Awaiting requested review from sikmir

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wunderbrick @r-rmcgibbo @SuperSandro2000 @sikmir