Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liblapack: disable failing tests on darwin #116579

Merged
merged 1 commit into from Mar 18, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Mar 17, 2021

Motivation for this change

Tests were enabled in #113021 and staging is broken since then.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS (aarch64 + x86_64)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 116579 at 8c295d9b run on x86_64-linux 1

122 packages marked as broken and skipped:
  • bareos
  • bonfire
  • cassandra_2_1
  • cassandra_2_2
  • gimpPlugins.exposureBlend
  • gimpPlugins.texturize
  • glimpsePlugins.exposureBlend
  • glimpsePlugins.texturize
  • gnome3.gnome-documents
  • hadoop
  • ...
2447 packages skipped due to time constraints:
  • R
  • abcl
  • actdiag (python38Packages.actdiag)
  • adapta-gtk-theme
  • adoptopenjdk-icedtea-web
  • aiodnsbrute
  • alloy (alloy5)
  • alloy4
  • almonds
  • anki
  • ...
20 packages built successfully:
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/science/math/liblapack/default.nix:59:3:

       |
    59 |   meta = with lib; {
       |   ^
    

Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also just disable the tests again. I don't know anything (and don't care to) about darwin, so if this fixes it for you, go ahead.

@bobrik
Copy link
Contributor Author

bobrik commented Mar 18, 2021

I'd rather keep tests enabled.

@bobrik bobrik mentioned this pull request Mar 18, 2021
21 tasks
@collares
Copy link
Member

This also needs to be rebased onto staging-next, I believe.

@veprbl
Copy link
Member

veprbl commented Mar 18, 2021

/rebase staging-next

Tests were enabled in NixOS#113021 and staging is broken since then.
@github-actions github-actions bot changed the base branch from staging to staging-next March 18, 2021 16:15
@github-actions github-actions bot closed this Mar 18, 2021
@github-actions
Copy link
Contributor

Rebased, please reopen the pull request to restart CI

@veprbl veprbl reopened this Mar 18, 2021
@FRidh FRidh merged commit 06c5ea2 into NixOS:staging-next Mar 18, 2021
@bobrik bobrik deleted the ivan/darwin-lapack branch April 9, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants