Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.hwi: 1.2.1 -> 2.0.0 #116598

Merged
merged 1 commit into from Mar 17, 2021
Merged

python3Packages.hwi: 1.2.1 -> 2.0.0 #116598

merged 1 commit into from Mar 17, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Mar 17, 2021

Motivation for this change

new major release

supersedes #116592

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 17, 2021

Result of nixpkgs-review pr 116598 at 76df5842 run on x86_64-linux 1

2 packages failed to build (new failures):

Result of nixpkgs-review pr 116598 at 76df5842 run on aarch64-linux 1

2 packages failed to build (new failures):

@fabaff
Copy link
Member

fabaff commented Mar 17, 2021

Result of nixpkgs-review pr 116598 run on x86_64-linux 1

2 packages built:
  • hwi (python38Packages.hwi)
  • python39Packages.hwi

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ew/pr-116598]$ ./results/hwi/bin/hwi -h
usage: hwi [-h] [--device-path DEVICE_PATH] [--device-type DEVICE_TYPE] [--password PASSWORD] [--stdinpass] [--chain {main,test,regtest,signet}] [--debug] [--fingerprint FINGERPRINT] [--version] [--stdin] [--interactive] [--expert]
           {enumerate,getmasterxpub,signtx,getxpub,signmessage,getkeypool,getdescriptors,displayaddress,setup,wipe,restore,backup,promptpin,togglepassphrase,sendpin,installudevrules} ...

Hardware Wallet Interface, version 2.0.0.
Access and send commands to a hardware wallet device. Responses are in JSON format.
[...]
ew/pr-116598/results/python39Packages.hwi/lib/python3.9/site-packages]$ python
Python 3.8.8 (default, Feb 19 2021, 11:04:50) 
[GCC 10.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from hwilib import hwwclient
>>> device = hwwclient.HardwareWalletClient(path, password, expert)
>>> device = hwwclient.HardwareWalletClient("", "", True)      
>>> device.fingerprint
>>> print(device.fingerprint)
None

Update looks good to me.

@prusnak prusnak merged commit 3f11469 into NixOS:master Mar 17, 2021
@prusnak prusnak deleted the hwi branch March 17, 2021 14:33
propagatedBuildInputs = [
bitbox02
ecdsa
hidapi
libusb1
mnemonic
pyaes
typing-extensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package shouldn't be required in 3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants