Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfslicer: unvendor dependencies #116617

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 17, 2021

I get

CMake Error at cmake-modules/Utils.cmake:4 (get_target_property):
  get_target_property() called with non-existent target "range-v3".
Call Stack (most recent call first):
  src/backend/CMakeLists.txt:17 (target_link_libraries_system)


CMake Error at cmake-modules/Utils.cmake:4 (get_target_property):
  get_target_property() called with non-existent target
  "fmt::fmt-header-only".
Call Stack (most recent call first):
  src/CMakeLists.txt:16 (target_link_libraries_system)


CMake Error at cmake-modules/Utils.cmake:4 (get_target_property):
  get_target_property() called with non-existent target "spdlog".
Call Stack (most recent call first):
  src/CMakeLists.txt:16 (target_link_libraries_system)

Does someone know how to fix that?

Motivation for this change

#115627 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @strager @junrrein

set (RANGE_V3_PERF OFF)
set (RANGE_V3_HEADER_CHECKS OFF)
-add_subdirectory (range-v3)
+find_package (range-v3 REQUIRED)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://stackoverflow.com/a/59035863/4446318 you would need to use add_library.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

produces the exact same output

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I poked at this as well, and couldn't get it to work (although I don't know anything about CMake). I suspect someone whose proficient with CMake could whip this into shape.

@stale
Copy link

stale bot commented Sep 14, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 14, 2021
@dotlambda dotlambda closed this Jan 17, 2024
@dotlambda dotlambda deleted the pdfslicer-unvendor branch January 17, 2024 05:22
@dotlambda dotlambda restored the pdfslicer-unvendor branch January 17, 2024 05:27
@dotlambda dotlambda reopened this Jan 17, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 17, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants