New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdfslicer: unvendor dependencies #116617
base: master
Are you sure you want to change the base?
pdfslicer: unvendor dependencies #116617
Conversation
set (RANGE_V3_PERF OFF) | ||
set (RANGE_V3_HEADER_CHECKS OFF) | ||
-add_subdirectory (range-v3) | ||
+find_package (range-v3 REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://stackoverflow.com/a/59035863/4446318 you would need to use add_library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
produces the exact same output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I poked at this as well, and couldn't get it to work (although I don't know anything about CMake). I suspect someone whose proficient with CMake could whip this into shape.
I marked this as stale due to inactivity. → More info |
I get
Does someone know how to fix that?
Motivation for this change
#115627 (comment)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @strager @junrrein