Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sphinx-autobuild: Use correct package #116624

Merged
merged 2 commits into from Mar 24, 2021
Merged

sphinx-autobuild: Use correct package #116624

merged 2 commits into from Mar 24, 2021

Conversation

akshaymankar
Copy link
Contributor

Motivation for this change

The sphinx-autobuild attribute wrongly points to sphinx-argparse. This causes sphinx-autobuild to not be installable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@akshaymankar please correct the meta of the package. maintainers is missing an s I think.

@akshaymankar
Copy link
Contributor Author

@akshaymankar please correct the meta of the package. maintainers is missing an s I think.

Yep, fixed it now.

@ofborg ofborg bot requested a review from HolgerPeters March 17, 2021 21:33
@FRidh FRidh merged commit a62e67c into NixOS:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@HolgerPeters HolgerPeters Awaiting requested review from HolgerPeters

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akshaymankar @SuperSandro2000 @FRidh @Janik-Haag