Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apostrophe: 2.3 -> 2.4 #116635

Merged
merged 1 commit into from Mar 22, 2021
Merged

apostrophe: 2.3 -> 2.4 #116635

merged 1 commit into from Mar 22, 2021

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Mar 17, 2021 •
edited

https://gitlab.gnome.org/somas/apostrophe/-/releases/v2.4

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 17, 2021 •
edited

Result of nixpkgs-review pr 116635 at 4947462 run on aarch64-linux 1

1 package built successfully:
2 suggestions:
  • warning: meson-cmake

    Meson uses CMake as a fallback dependency resolution method and it likely is not necessary here. The message about cmake not being found is purely informational.

    Near pkgs/applications/editors/apostrophe/default.nix:26:3:

       |
26 |   nativeBuildInputs = [ meson ninja cmake pkg-config desktop-file-utils
   |   ^
  • warning: unclear-gpl

    gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/editors/apostrophe/default.nix:49:5:

       |
49 |     license = licenses.gpl3;
   |     ^

Result of nixpkgs-review pr 116635 at 4947462 run on x86_64-linux 1

1 package built successfully:
2 suggestions:
  • warning: meson-cmake

    Meson uses CMake as a fallback dependency resolution method and it likely is not necessary here. The message about cmake not being found is purely informational.

    Near pkgs/applications/editors/apostrophe/default.nix:26:3:

       |
26 |   nativeBuildInputs = [ meson ninja cmake pkg-config desktop-file-utils
   |   ^
  • warning: unclear-gpl

    gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/editors/apostrophe/default.nix:49:5:

       |
49 |     license = licenses.gpl3;
   |     ^

@SuperSandro2000 SuperSandro2000 merged commit db810a9 into NixOS:master Mar 22, 2021
@sternenseemann sternenseemann deleted the apostrophe-2.4 branch March 22, 2021 08:41
@tasmo
Copy link
Contributor

tasmo commented Mar 29, 2021

Is not building here because of its dependency pandoc-citeproc which fails with a build error.

@sternenseemann
Copy link
Member Author

pandoc-citeproc is actually unmaintained these days… I'll see if it apostrophe has already removed it in favor of pandoc --citeproc or I'll have to find a way to intermittently unbreak pandoc-citeproc. Thank you for the report.

sternenseemann added a commit to sternenseemann/nixpkgs that referenced this pull request Mar 29, 2021
@sternenseemann
python3Packages.pypandoc: vendor patches, test w/o pandoc-citeproc
0602ece 
* Translate all seds in postPatch into patches (for setting the static
  path and skipping the test that needs network access)
* The patch for the changed pandoc heading generation was simplified:
  Since we know our pandoc version is always that new, we can skip the
  version check.
* Skip the test for pandoc-citeproc: pandoc-citeproc has been deprecated
  in favor of pandoc --citeproc by the upstream pandoc developer.
  pypandoc's testsuite doesn't reflect this yet (although it should
  support --citeproc theoretically) to avoid depending on
  pandoc-citeproc for the checkPhase (as we expect it to break again or
  continue to be broken) we skip the test requiring pandoc-citeproc.

The breakage of pypandoc due to pandoc-citeproc was pointed out here:
NixOS#116635 (comment)
Thank you!
@sternenseemann sternenseemann mentioned this pull request Mar 29, 2021
Merged
10 tasks
@sternenseemann
Copy link
Member Author

@tasmo care to test #117938?

@tasmo
Copy link
Contributor

tasmo commented Mar 29, 2021

@sternenseemann Yes, the #117938 works well. Thank you!

sternenseemann added a commit that referenced this pull request Apr 9, 2021
@sternenseemann
python3Packages.pypandoc: vendor patches, test w/o pandoc-citeproc
27077f1 
* Translate all seds in postPatch into patches (for setting the static
  path and skipping the test that needs network access)
* The patch for the changed pandoc heading generation was simplified:
  Since we know our pandoc version is always that new, we can skip the
  version check.
* Skip the test for pandoc-citeproc: pandoc-citeproc has been deprecated
  in favor of pandoc --citeproc by the upstream pandoc developer.
  pypandoc's testsuite doesn't reflect this yet (although it should
  support --citeproc theoretically) to avoid depending on
  pandoc-citeproc for the checkPhase (as we expect it to break again or
  continue to be broken) we skip the test requiring pandoc-citeproc.

The breakage of pypandoc due to pandoc-citeproc was pointed out here:
#116635 (comment)
Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sternenseemann @r-rmcgibbo @tasmo @SuperSandro2000