New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.lxml: fix build on darwin #116669
Conversation
I believe this needs to be rebased on |
|
@SuperSandro2000 your command seems to rebase onto
It may be easier to ask the bot to do the right thing. |
/rebase staging |
|
🤔 might be. Using the bot is not a bad idea. |
/rebase staging-next |
Rebased, please reopen the pull request to restart CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is setupinfo.py setting _ldflags=['-isysroot', '']
and and some layer the empty string is omitted. It determines the location of the sysroot from the output of xcrun --show-sdk-path
. This PR fixes it by adding an xcrun
in the build environment that provides a valid path instead of the empty string, but it's also possible to patch the _ldflags
out of setupinfo.py
entirely and avoid the dependency. Either way works, but this requires less patching, so LGTM.
Motivation for this change
Update in #107408 broke it for Darwin.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)