Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta-fetch: etc #116674

Closed
wants to merge 1 commit into from
Closed

meta-fetch: etc #116674

wants to merge 1 commit into from

Conversation

CohenCyril
Copy link
Contributor

Motivation for this change

Attempt to fix #116670

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril CohenCyril mentioned this pull request Mar 17, 2021
Closed
@CohenCyril CohenCyril changed the title meta-fetch: etc meta-fetcher: etc Mar 18, 2021
@CohenCyril CohenCyril changed the title meta-fetcher: etc meta-fetch: etc Mar 18, 2021
@CohenCyril
Copy link
Contributor Author

@GrahamcOfBorg build coqPackages

@CohenCyril
Copy link
Contributor Author

@GrahamcOfBorg build coqPackage_8_11

doronbehar
doronbehar reviewed Mar 28, 2021
View reviewed changes
pkgs/build-support/coq/meta-fetch/default.nix
let lib = import ../extra-lib.nix {lib = lib';}; in
with builtins; with lib;
let lib' = import ../extra-lib.nix {inherit lib;}; in
with builtins; with lib';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about not using with for such a large scope at all? See:
https://nix.dev/anti-patterns/language.html#with-attrset-expression

@doronbehar
Copy link
Contributor

GrahamcOfBorg build coqPackage_8_11

ofborg doesn't build unfree packages (don't know why it's unfree).

@stale
Copy link

stale bot commented Sep 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 26, 2021
@doronbehar doronbehar closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined variable 'isPath' in pkgs/build-support/coq/meta-fetch/default.nix
2 participants
@CohenCyril @doronbehar