Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procps-ng: cleanup, format, remove ? null from inputs #116676

Merged
merged 1 commit into from Mar 18, 2021
Merged

procps-ng: cleanup, format, remove ? null from inputs #116676

merged 1 commit into from Mar 18, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from typetetris March 17, 2021 22:05
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 116676 at d6772e3a run on aarch64-linux 1

57 packages marked as broken and skipped:
  • bless
  • cassandra_2_1
  • cassandra_2_2
  • credhub-cli
  • gitin
  • go_1_14
  • gogoclient
  • lefthook
  • libsForQt512.discover
  • libsForQt514.discover
  • ...
2 packages failed to build (new failures):
833 packages skipped due to time constraints:
  • act
  • adapta-gtk-theme
  • aerc
  • age
  • air
  • alertmanager-bot
  • almanah
  • amass
  • amazon-ecr-credential-helper
  • amfora
  • ...
380 packages built successfully:
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/os-specific/linux/procps-ng/default.nix:55:3:

       |
55 |   installPhase = lib.optionalString watchOnly ''
   |   ^
  • warning: unclear-gpl

    gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/os-specific/linux/procps-ng/default.nix:64:5:

       |
64 |     license = licenses.gpl2;
   |     ^

@SuperSandro2000
Copy link
Member Author

/rebase staging

@github-actions github-actions bot changed the base branch from master to staging March 18, 2021 00:49
@github-actions github-actions bot closed this Mar 18, 2021
@github-actions
Copy link
Contributor

Rebased, please reopen the pull request to restart CI

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116676 run on x86_64-linux 1

1 package built:
  • procps-ng

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

procps-ng:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/os-specific/linux/procps-ng/default.nix:64:5:

   |
64 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@SuperSandro2000 SuperSandro2000 merged commit 3fbea57 into NixOS:staging Mar 18, 2021
@SuperSandro2000 SuperSandro2000 deleted the procps-ng branch March 18, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typetetris typetetris Awaiting requested review from typetetris

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @r-rmcgibbo