Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.ocaml-freestanding: init at 0.6.4 #116693

Merged
merged 1 commit into from Mar 26, 2021

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Mar 18, 2021

Motivation for this change

#23955

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@ofborg build ocaml-ng.ocamlPackages_4_08.ocaml-freestanding ocaml-ng.ocamlPackages_4_09.ocaml-freestanding ocaml-ng.ocamlPackages_4_10.ocaml-freestanding ocaml-ng.ocamlPackages_4_11.ocaml-freestanding ocaml-ng.ocamlPackages_4_12.ocaml-freestanding

@sternenseemann sternenseemann force-pushed the ocaml-freestanding branch 2 times, most recently from ce3a51d to d4c4155 Compare March 26, 2021 10:37
@sternenseemann
Copy link
Member Author

@ofborg build ocamlPackages.ocaml-freestanding

@vbgl
Copy link
Contributor

vbgl commented Mar 26, 2021

This seems to require OCaml ≥ 4.08

Contains vendored in patches from mirage/ocaml-solo5#93
to make building within nixpkgs simpler. These serve as a makeshift
solution until ocaml-freestanding is released with its overhauled dune
based build system which will also support cross compiling. Upstream has
indicated that they are interested in making it work well with nix as
well.
@sternenseemann
Copy link
Member Author

This seems to require OCaml ≥ 4.08

You're right, fixed.

@vbgl vbgl merged commit 13a8519 into NixOS:master Mar 26, 2021
@sternenseemann sternenseemann deleted the ocaml-freestanding branch March 26, 2021 11:49
@sternenseemann sternenseemann restored the ocaml-freestanding branch July 24, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants