Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiki-js: init at 2.5.191 #116738

Merged
merged 3 commits into from Mar 27, 2021
Merged

wiki-js: init at 2.5.191 #116738

merged 3 commits into from Mar 27, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 18, 2021

Motivation for this change

Package for https://js.wiki

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 116738 at fcaf371d run on x86_64-linux 1

1 package built successfully:
  • wiki-js
1 suggestion:
  • warning: unclear-gpl

    agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

    Near pkgs/servers/web-apps/wiki-js/default.nix:22:5:

       |
    22 |     license = licenses.agpl3;
       |     ^
    

@Ma27
Copy link
Member Author

Ma27 commented Mar 21, 2021

@SuperSandro2000 anything else missing to get this merged? :)

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 anything else missing to get this merged? :)

I just left one little remark about the package. Not sure of the module or test is all right.

pkgs/servers/web-apps/wiki-js/default.nix Outdated Show resolved Hide resolved
@Ma27 Ma27 merged commit ae73ec2 into NixOS:master Mar 27, 2021
@Ma27 Ma27 deleted the wiki-js branch March 27, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants