New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logseq: init at 0.0.13 #116745
logseq: init at 0.0.13 #116745
Conversation
Result of 1 package built:
|
@weihua-lu looks pretty good, can you rebase/squash to have 2 commits? One to add yourself into the maintainer list and the logseq-specific commits squashed? |
@tomberek done, thanks for reviewing this! |
''; | ||
|
||
postFixup = '' | ||
makeWrapper ${electron}/bin/electron $out/bin/${pname} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @weihua-lu, I'm investigating a nixos-specific issue with logseq (logseq/logseq#3132) and I was wondering: why are we providing our own version of electron here? The appimage runs fine on its own, does that not mean it could run without this wrapping?
I'm asking because the appimage on its own doesn't have the issue.
Motivation for this change
logseq
is a local-first, non-linear, outliner notebook for organizing and sharing personal knowledge base.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)