Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logseq: init at 0.0.13 #116745

Merged
merged 2 commits into from Mar 20, 2021
Merged

logseq: init at 0.0.13 #116745

merged 2 commits into from Mar 20, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2021

Motivation for this change

logseq is a local-first, non-linear, outliner notebook for organizing and sharing personal knowledge base.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/applications/misc/logseq/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/logseq/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/logseq/default.nix Show resolved Hide resolved
@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 116745 run on x86_64-linux 1

1 package built:
  • logseq

@tomberek
Copy link
Contributor

@weihua-lu looks pretty good, can you rebase/squash to have 2 commits? One to add yourself into the maintainer list and the logseq-specific commits squashed?

@ghost
Copy link
Author

ghost commented Mar 20, 2021

@tomberek done, thanks for reviewing this!

@tomberek tomberek merged commit 594ebb5 into NixOS:master Mar 20, 2021
'';

postFixup = ''
makeWrapper ${electron}/bin/electron $out/bin/${pname} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @weihua-lu, I'm investigating a nixos-specific issue with logseq (logseq/logseq#3132) and I was wondering: why are we providing our own version of electron here? The appimage runs fine on its own, does that not mean it could run without this wrapping?
I'm asking because the appimage on its own doesn't have the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants