Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trunk: init at 0.10.0 #116751

Merged
merged 1 commit into from Mar 21, 2021
Merged

trunk: init at 0.10.0 #116751

merged 1 commit into from Mar 21, 2021

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

New package for a rust/wasm devtool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.


cargoSha256 = "Qv7knTmNYtw0tbyWhFIV7tYkQiwFxcNPAeNiGCyeV8s=";

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116751 run on x86_64-linux 1

1 package built:
  • trunk

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

trunk:

warning: license-missing
Package is missing a license

Near pkgs/build-support/rust/default.nix:142:3:

    |
142 |   meta = {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

@freezeboy
Copy link
Contributor Author

Thank you, license added

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 116751 run on x86_64-linux 1

1 package built:
  • trunk

@tomberek tomberek merged commit 8322217 into NixOS:master Mar 21, 2021
@freezeboy freezeboy deleted the add-trunk branch March 21, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants