Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sunwait: init at 20201026 #116762

Merged
merged 1 commit into from Mar 20, 2021
Merged

sunwait: init at 20201026 #116762

merged 1 commit into from Mar 20, 2021

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 18, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 116762 at 3113c3d0 run on aarch64-linux 1

1 package built successfully:
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/misc/sunwait/default.nix:16:3:

       |
    16 |   installPhase = ''
       |   ^
    
  • warning: unclear-gpl

    gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/misc/sunwait/default.nix:23:5:

       |
    23 |     license = licenses.gpl3;
       |     ^
    

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 116762 run on x86_64-linux 1

1 package built:
  • sunwait

@tomberek tomberek merged commit 19f6178 into NixOS:master Mar 20, 2021
@etu etu deleted the init-sunwait branch March 20, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants