Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magnetophonDSP.MBdistortion: fix build #116763

Merged
merged 1 commit into from Mar 20, 2021

Conversation

sternenseemann
Copy link
Member

Apply upstream patch fixing the issue observed in nixpkgs previously.
Resolves #114854. Thanks to @turboMaCk for fixing this up and
reporting back.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Apply upstream patch fixing the issue observed in nixpkgs previously.
Resolves NixOS#114854. Thanks to Marek Fajkus for fixing this up and
reporting back.
Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 116763 at 5c3029e run on x86_64-linux 1

1 package built successfully:
4 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/audio/magnetophonDSP/MBdistortion/default.nix:14:5:

       |
    14 |     (fetchpatch {
       |     ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/applications/audio/magnetophonDSP/MBdistortion/default.nix:22:3:

       |
    22 |   buildPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/audio/magnetophonDSP/MBdistortion/default.nix:27:3:

       |
    27 |   installPhase = ''
       |   ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/audio/magnetophonDSP/MBdistortion/default.nix:37:5:

       |
    37 |     license = lib.licenses.gpl2;
       |     ^
    

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 116763 run on x86_64-linux 1

1 package built:
  • magnetophonDSP.MBdistortion

@tomberek tomberek merged commit be003e3 into NixOS:master Mar 20, 2021
@magnetophon
Copy link
Member

Thanks all, sorry to be MIA.

@sternenseemann sternenseemann deleted the MBdistortion-build-fix branch March 21, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

magnetophonDSP.MBDistortion build is broken
5 participants