appdaemon: fix astral dependency

[mbrgm]

Motivation for this change

appdaemon v4.0.5 pins astral to v1.10.1. The appdaemon package
definition removes this pinning. However, the current nixpkgs version of
astral (v2.x) is incompatible with the v1.x API. I added an override for
the astral package to bring back v1.10.1 into this derivation.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[dotlambda]

The line --replace "astral==1.10.1" "astral" \ can be removed.

[dotlambda]

Can you add a link to an upstream issue?

[mbrgm]

There is no upstream issue. The derivation introduces the regression by unpinning the astral package version. See the commit message for detailed information. Here's a traceback of the symptom:

Mar 17 00:38:00 nixos appdaemon[9134]: Traceback (most recent call last):
Mar 17 00:38:00 nixos appdaemon[9134]:   File "/nix/store/la71x6y3npq1fzrvkv2f7kb481c2yls4-appdaemon-4.0.5/lib/python3.8/site-packages/appdaemon/__main__.py", line 117,>
Mar 17 00:38:00 nixos appdaemon[9134]:     self.AD = ad.AppDaemon(self.logging, loop, **appdaemon)
Mar 17 00:38:00 nixos appdaemon[9134]:   File "/nix/store/la71x6y3npq1fzrvkv2f7kb481c2yls4-appdaemon-4.0.5/lib/python3.8/site-packages/appdaemon/appdaemon.py", line 187>
Mar 17 00:38:00 nixos appdaemon[9134]:     self.sched = scheduler.Scheduler(self)
Mar 17 00:38:00 nixos appdaemon[9134]:   File "/nix/store/la71x6y3npq1fzrvkv2f7kb481c2yls4-appdaemon-4.0.5/lib/python3.8/site-packages/appdaemon/scheduler.py", line 62,>
Mar 17 00:38:00 nixos appdaemon[9134]:     self.init_sun()
Mar 17 00:38:00 nixos appdaemon[9134]:   File "/nix/store/la71x6y3npq1fzrvkv2f7kb481c2yls4-appdaemon-4.0.5/lib/python3.8/site-packages/appdaemon/scheduler.py", line 220>
Mar 17 00:38:00 nixos appdaemon[9134]:     self.location = astral.Location(("", "", latitude, longitude, self.AD.tz.zone, elevation))
Mar 17 00:38:00 nixos appdaemon[9134]: AttributeError: module 'astral' has no attribute 'Location'

[dotlambda]

Can we use the patches from AppDaemon/appdaemon#1168 instead?

[mbrgm]

Can we use the patches from AppDaemon/appdaemon#1168 instead?

Sure... however upstream author is planning to release a new version soon (AppDaemon/appdaemon#1217) and my motivation to rebase the patch you mentioned and re-author this PR is quite low regarding it would only be effective for a few days and I have a solution in place already. So I'd either stay with this fix or close the PR to wait for the new appdaemon version.