Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xedit: init at 1.2.2 #116778

Merged
merged 1 commit into from Jan 2, 2022
Merged

xedit: init at 1.2.2 #116778

merged 1 commit into from Jan 2, 2022

Conversation

SCOTT-HAMILTON
Copy link
Contributor

@SCOTT-HAMILTON SCOTT-HAMILTON commented Mar 18, 2021

Motivation for this change

Closes #116684

Things done

Packaged Xedit.

Couldn't make it working, I got : stderr

Error: Shell widget fileMenu has zero width and/or height

Return value : 1

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/applications/editors/xedit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/xedit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/xedit/default.nix Outdated Show resolved Hide resolved
@taku0
Copy link
Contributor

taku0 commented Mar 27, 2021

Executing xedit results in Error: Shell widget fileMenu has zero width and/or height.

@jonringer
Copy link
Contributor

please resolve merge conflicts

@dasJ
Copy link
Member

dasJ commented Nov 22, 2021

Why would a new package go against staging?

@SCOTT-HAMILTON
Copy link
Contributor Author

Why would a new package go against staging?

I thought staging was the default now because master was becoming a mess.

@SuperSandro2000 SuperSandro2000 changed the base branch from staging to master January 1, 2022 14:11
@SuperSandro2000
Copy link
Member

I thought staging was the default now because master was becoming a mess.

No, that is not the case.

@SuperSandro2000 SuperSandro2000 merged commit e671fb7 into NixOS:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packaging request: xedit
5 participants