Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluxcd: 0.8.2 -> 0.10.0 #116794

Merged
merged 1 commit into from Mar 19, 2021
Merged

fluxcd: 0.8.2 -> 0.10.0 #116794

merged 1 commit into from Mar 19, 2021

Conversation

thmzlt
Copy link
Contributor

@thmzlt thmzlt commented Mar 18, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and jlesquembre March 18, 2021 23:02
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/481

@thmzlt thmzlt force-pushed the fluxcd branch 2 times, most recently from f363533 to 6c0ee00 Compare March 19, 2021 11:54
@ofborg ofborg bot requested a review from jlesquembre March 19, 2021 12:03
@ofborg ofborg bot requested a review from jlesquembre March 19, 2021 13:07
@SuperSandro2000 SuperSandro2000 merged commit 83a19ff into NixOS:master Mar 19, 2021
@thmzlt thmzlt deleted the fluxcd branch March 19, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thmzlt @nixos-discourse @jlesquembre @SuperSandro2000