Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab: add option for tls wrapper-mode smtp #116801

Merged
1 commit merged into from Mar 20, 2021
Merged

nixos/gitlab: add option for tls wrapper-mode smtp #116801

1 commit merged into from Mar 20, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2021

Motivation for this change

This is required when SMTP with TLS wrapped-mode on port 465 is used as shown here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from talyz March 18, 2021 23:55
@ghost ghost merged commit 58804b2 into NixOS:master Mar 20, 2021
globin pushed a commit to mayflower/nixpkgs that referenced this pull request Mar 27, 2021
@globin
nixos/gitlab: add option for tls wrapper-mode smtp (NixOS#116801)
74361b9 
(cherry picked from commit 58804b2)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
0 participants