spotify-unwrapped: 1.1.46.916.g416cacf1 -> 1.1.55.494.gca75f788

[samuela]

Motivation for this change

Upgrades spotify-unwrapped from 1.1.46.916.g416cacf1 to 1.1.55.494.gca75f788

This PR was automatically generated by nixpkgs-upkeep.

• CI workflow that created this PR.
• Internal tag: 96fe581eb7f2ba2387b11e0da5dec28e.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 116805 at de7418b run on x86_64-linux 1

3 packages built successfully:

• spotify
• spotify-unwrapped
• spotifywm

1 suggestion:

• warning: build-tools-in-build-inputs

  squashfsTools is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/applications/audio/spotify/default.nix:85:3:

     |
  85 |   buildInputs = [ squashfsTools ];
     |   ^
  

[samuela]

Thanks @r-rmcgibbo for the suggestion! I fixed it in 3b84765.

The new version wasn't running for me so I fixed (what I believe to be) all the dependency issues in 78d3a4b.

[SuperSandro2000]

Does stripping break it?

[samuela]

I'm not sure. This was just the suggestion in @r-rmcgibbo's comment.

[samuela]

Oops, I just realized you commented on line 87, not 84-85... That's a great question re dontStrip. That decision was before my time... Perhaps one of the maintainers would know?

[timokau]

Good catch. This was already included in the original commit (f81bc24). I'd say there is a good chance that it is not needed (anymore). I think we should generally not require unrelated improvements on update PRs though.

[samuela]

Yeah, I'd be happy to submit a follow-up PR removing dontStrip

[SuperSandro2000]

So we don't need it?

Suggested change

dontStrip = true;

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116805 run on x86_64-linux 1

3 packages built:

• spotify
• spotify-unwrapped
• spotifywm

[timokau]

Looks good to me, thanks! I won't merge this yet because I don't want to step over @SuperSandro2000 regarding the dontStrip thread. In my opinion it is good to go though.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/360