Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watson: 1.10.0 -> 2.0.0 #116831

Merged
merged 2 commits into from Apr 12, 2021
Merged

watson: 1.10.0 -> 2.0.0 #116831

merged 2 commits into from Apr 12, 2021

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Mar 19, 2021

Motivation for this change

This pull request updates watson to its latest release. Therefore, the arrow dependency needs to be bumped first. Thus, this two changes are within this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 19, 2021 •
edited

Result of nixpkgs-review pr 116831 at aa3ed75a run on x86_64-linux 1

28 packages marked as broken and skipped:
  • bareos
  • bonfire
  • cassandra_2_1
  • cassandra_2_2
  • hadoop
  • hadoop_2_7
  • hadoop_2_8
  • hadoop_2_9
  • linuxPackages-libre.virtualbox
  • linuxPackages_hardkernel_4_14.virtualbox
  • ...
5 packages failed to build (new failures):
744 packages skipped due to time constraints:
  • R
  • abcl
  • adapta-gtk-theme
  • adoptopenjdk-icedtea-web
  • aiodnsbrute
  • alloy (alloy5)
  • alloy4
  • antlr
  • antlr3 (antlr3_5)
  • antlr3_4
  • ...
67 packages built successfully:

Result of nixpkgs-review pr 116831 at aa3ed75a run on aarch64-linux 1

41 packages marked as broken and skipped:
  • bareos
  • bonfire
  • cassandra_2_1
  • cassandra_2_2
  • openmodelica
  • opentsdb
  • pepper
  • pig
  • polymake
  • processing
  • ...
8 packages failed to build (new failures):
677 packages skipped due to time constraints:
  • R
  • abcl
  • adapta-gtk-theme
  • adoptopenjdk-icedtea-web
  • aiodnsbrute
  • alloy (alloy5)
  • alloy4
  • antlr
  • antlr3 (antlr3_5)
  • antlr3_4
  • ...
63 packages built successfully:

@oxzi
Copy link
Member Author

oxzi commented Mar 19, 2021

Oof. Seems like bumping arrow might have some side effects.

SuperSandro2000
SuperSandro2000 requested changes Mar 19, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best solution is to split of arrow 0.17.X and keep it as the default right now.

pkgs/development/python-modules/arrow/default.nix Outdated Show resolved Hide resolved
@oxzi
Copy link
Member Author

oxzi commented Mar 22, 2021

@SuperSandro2000: Thanks for your review. I have altered the PR to contain an extra arrow package for major version one. Additionally, I will create an issue regarding arrow and notify its maintainer.

@oxzi oxzi mentioned this pull request Mar 22, 2021
Closed
2 tasks
SuperSandro2000
SuperSandro2000 requested changes Apr 6, 2021
View reviewed changes
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/office/watson/default.nix Outdated Show resolved Hide resolved
oxzi and others added 2 commits April 6, 2021 09:12
@oxzi
pythonPackages.arrow_1: init at 1.0.3
95794c4 
This is an alternative arrow package for the new major version one. The
other package is still at 0.17 and bumping it will result in a huge
amount of rebuilds. However, some packages are depending on the new
release, e.g., watson.
@oxzi @SuperSandro2000
watson: 1.10.0 -> 2.0.0
6e7740f 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@oxzi
Copy link
Member Author

oxzi commented Apr 6, 2021

@SuperSandro2000: Thanks, I have moved the modified arrow package to its "main" directory, as you suggested.

@SuperSandro2000 SuperSandro2000 merged commit 1bbb088 into NixOS:master Apr 12, 2021
@oxzi oxzi deleted the watson-2.0.0 branch April 18, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@nathyong nathyong Awaiting requested review from nathyong

@mguentner mguentner Awaiting requested review from mguentner

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @r-rmcgibbo @SuperSandro2000