Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-valgrind: 1.3.0 -> 2.0.0 #116839

Closed
wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for cargo-valgrind is: "Cargo subcommand "valgrind": runs valgrind and collects its output in a helpful manner"

meta.homepage for cargo-valgrind is: "https://github.com/jfrimmel/cargo-valgrind"

meta.changelog for cargo-valgrind is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
cargo-valgrind
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/38g0sgx11x55m6wwh80ijy11hq4nlsjq-cargo-valgrind-2.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A cargo-valgrind https://github.com/r-ryantm/nixpkgs/archive/fb1a11c878b07875e24b366a67e66f58c3cd54af.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/38g0sgx11x55m6wwh80ijy11hq4nlsjq-cargo-valgrind-2.0.0
ls -la /nix/store/38g0sgx11x55m6wwh80ijy11hq4nlsjq-cargo-valgrind-2.0.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • cargo-valgrind

Maintainer pings

cc @otavio for testing.


src = fetchFromGitHub {
owner = "jfrimmel";
repo = "cargo-valgrind";
# repo lacks the 1.3.0 tag
# repo lacks the 2.0.0 tag
# https://github.com/jfrimmel/cargo-valgrind/issues/33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue and comment are no longer needed as the tag has been pushed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a PR with this update and the fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was going to be done by the PR proposer. I'll look at this tomorrow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otavio r-ryantm is a bot that automatically makes PRs

@otavio
Copy link
Contributor

otavio commented Mar 22, 2021

Opened in #117249. This can be closed.

@otavio otavio closed this Mar 22, 2021
@r-ryantm r-ryantm deleted the auto-update/cargo-valgrind branch March 22, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants