Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-language-server: Fix build #116841

Merged
merged 1 commit into from Mar 19, 2021
Merged

haskell-language-server: Fix build #116841

merged 1 commit into from Mar 19, 2021

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Mar 19, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
Copy link
Member Author

I will merge this once @GrahamcOfBorg signals success.

@maralorn
Copy link
Member Author

@GrahamcOfBorg build haskell-language-server

@maralorn
Copy link
Member Author

I don‘t understand why the x86 build failed.

@GrahamcOfBorg build haskell-language-server

@maralorn
Copy link
Member Author

@GrahamcOfBorg build haskell-language-server

@maralorn maralorn merged commit 6e9ca2d into NixOS:haskell-updates Mar 19, 2021
@maralorn maralorn deleted the hls branch March 19, 2021 14:56
@SuperSandro2000
Copy link
Member

I think the pipeline breakage is not from this PR but from some earlier. Still it is not great that we cannot rely on ofborg to check if everything evals. It would be nice if someone could look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @SuperSandro2000