haxe: add 4.2.1 and update default version

[sternenseemann]

Motivation for this change

#116302 with a few cleanups and without removing the old compilers.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[sternenseemann]

@ofborg build neko haxe haxe_3_2 haxe_3_4 haxe_4_0 haxe_4_1

[locallycompact]

Looks good to me.

[r-rmcgibbo]

Result of nixpkgs-review pr 116953 at bf0dbb41 run on x86_64-linux 1

10 packages built successfully:

• haxe
(haxe_4_2)
• hxcpp
(haxePackages.hxcpp)
• haxePackages.hxcs
• haxePackages.hxjava
• haxePackages.hxnodejs_4
• haxe_3_2
• haxe_3_4
• haxe_4_0
• haxe_4_1
• neko

3 suggestions:

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/development/compilers/haxe/default.nix:51:7:

     |
  51 |       installPhase = ''
     |       ^
  

• warning: unclear-gpl

  gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/development/compilers/haxe/default.nix:107:9:

      |
  107 |         license = with licenses; [ gpl2 bsd2 /*?*/ ];  # -> docs/license.txt
      |         ^
  

• warning: unclear-gpl

  lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

  Near pkgs/development/compilers/neko/default.nix:36:5:

     |
  36 |     license = licenses.lgpl21;
     |     ^
  

---

Result of nixpkgs-review pr 116953 at bf0dbb41 run on aarch64-linux 1

2 packages marked as broken and skipped:

• haxe_3_2
• haxe_3_4

8 packages built successfully:

• haxe
(haxe_4_2)
• hxcpp
(haxePackages.hxcpp)
• haxePackages.hxcs
• haxePackages.hxjava
• haxePackages.hxnodejs_4
• haxe_4_0
• haxe_4_1
• neko

3 suggestions:

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/development/compilers/haxe/default.nix:51:7:

     |
  51 |       installPhase = ''
     |       ^
  

• warning: unclear-gpl

  gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/development/compilers/haxe/default.nix:107:9:

      |
  107 |         license = with licenses; [ gpl2 bsd2 /*?*/ ];  # -> docs/license.txt
      |         ^
  

• warning: unclear-gpl

  lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

  Near pkgs/development/compilers/neko/default.nix:36:5:

     |
  36 |     license = licenses.lgpl21;
     |     ^
  

[aszlig]

LGTM, although I didn't take a detailed look at it, nor did I test it.

[locallycompact]

@sternenseemann If you're interested I could use help with hashlink as well. #116321

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116953 run on x86_64-linux 1

10 packages built:

• haxe (haxe_4_2)
• hxcpp (haxePackages.hxcpp)
• haxePackages.hxcs
• haxePackages.hxjava
• haxePackages.hxnodejs_4
• haxe_3_2
• haxe_3_4
• haxe_4_0
• haxe_4_1
• neko

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

haxe:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/development/compilers/haxe/default.nix:107:9:

    |
107 |         license = with licenses; [ gpl2 bsd2 /*?*/ ];  # -> docs/license.txt
    |         ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

[sternenseemann]

@ofborg build neko haxe haxe_3_2 haxe_3_4 haxe_4_0 haxe_4_1

[sternenseemann]

I've dropped haxe 4.1 and 4.0 because they require us to jump through hoops for extlib as they need < 1.7.7. I can add them back if we absolutely need them, but would prefer not to.

[OPNA2608]

Built lukaskj/haxe-example targets "cpp", "cs", "java" and "executable" (neko) on Haxe 4.2. All build results ran fine, either on their own or under their respective runtime.

Locally packaged haxeui/hxWidgets + dependencies, built one of its sample GUI projects on Haxe 4.2 and 3.4 (this PR) and 3.4 (current master). All build results ran fine.

(Used overlay for & screenshot of hxWidgets here)

self: super: rec {

  haxePackages = super.haxePackages // {
    hscript = super.haxePackages.buildHaxeLib rec {
      libname = "hscript";
      version = "2.4.0";
      sha256 = "0qdxgqb75j1v125l9xavs1d32wwzi60rhfymngdhjqhdvq72bhxx";
      meta.description = "Haxe Script is a scripting engine for a subset of the Haxe language";
    };
    hxWidgets = super.haxePackages.buildHaxeLib rec {
      libname = "hxWidgets";
      version = "1.7.2";
      sha256 = "1ki90m2qqyqmcmwd97id4ck9rr25dvdlnmfp53bg8prcyg41wbgf";
      meta.description = "Haxe externs (and wrappers) for wxWidgets";
      propagatedBuildInputs = with super; [ wxGTK31 libGL ];
    };
  };

  haxetest = super.callPackage (

{ stdenv
, haxe, haxePackages
}:

stdenv.mkDerivation rec {
  pname = "haxetest";
  version = "irrelevant";
  
  src = haxePackages.hxWidgets.src;
  
  nativeBuildInputs = [ haxe ] ++ (with haxePackages; [ hxcpp hscript hxWidgets ]);
  
  buildPhase = "cd samples/00-Showcase && haxe build.hxml";
  
  installPhase = ''
    install -Dm755 bin/Main $out/bin/00-Showcase
  '';
}
 
  ) { };
}

LGTM.

[sternenseemann]

Great, thank you for your help! If there aren't any other comments, I think we can merge and then (re)introduce 4.0 and 4.1 in the next PR!

[OPNA2608]

As a more complex test, I also managed to get Friday Night Funkin' compiled & running with Haxe 4.2, though only v0.2.7.1. Building the current master with some required patches gets… stuck? Haxelib, Neko and its GCC subprocesses just keep eating away at the CPU without any new compiled results. I assume its a problem with one of the dependencies/FNF and not Haxe/Neko itself.

I'll still look forward to the 4.1 PR 🙂

[sternenseemann]

@ofborg build haxe_3_2 haxe_3_4 neko