Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.onnx: fix build #116959

Merged
merged 1 commit into from Mar 24, 2021
Merged

python3Packages.onnx: fix build #116959

merged 1 commit into from Mar 24, 2021

Conversation

tfmoraes
Copy link
Contributor

@tfmoraes tfmoraes commented Mar 19, 2021

Motivation for this change

Python-onnx was not building because of a shebang not being patched.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 19, 2021

Result of nixpkgs-review pr 116959 at 6a3ab6a5 run on aarch64-linux 1

2 packages built successfully:

Result of nixpkgs-review pr 116959 at 6a3ab6a5 run on x86_64-linux 1

2 packages built successfully:

Copy link
Contributor

@acairncross acairncross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116959 run on x86_64-linux 1

2 packages built:
  • python38Packages.onnx
  • python39Packages.onnx

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.onnx:

warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

@FRidh FRidh merged commit ac977c3 into NixOS:master Mar 24, 2021
@tfmoraes tfmoraes deleted the onnx_shebang branch March 24, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants