Add package: plowshare-git20120807 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 26, 2012 14:43
|
After some advice on the nix-dev mailing list I updated the branch and would like to get this merged into master if there are no other issues with the Nix expression. |
Profpatsch
pushed a commit
that referenced
this pull request
Jun 20, 2020
thinkpad: minor trackpoint fixes
ethancedwards8
pushed a commit
to ethancedwards8/nixpkgs
that referenced
this pull request
Apr 2, 2021
All the checks are now aggregated in system.checks.text making it easy
to allow certain checks to be disabled as well as disabling them
alltogether if desired. eg.
# Disable all checks.
system.checks.text = mkForce "";
Fixes NixOS#117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds plowshare to Nixpkgs. I built and tested it locally and it is working fine for me. However, I am wondering if the Nix expression is correct.
plowshare is just a bunch of Bash scripts which call other programs, e.g. curl. Mind that curl is not mentioned in plowshare's dependencies. I didn't perform any wrapping of the shell scripts. Does this make the Nix expression impure? What is the recommended way to improve this?
I was expecting that plowshare wouldn't work at all, but even after removing curl from my user account in NixOS it apparently picked up the right binaries. So I am a little confused if I should patch anything at all.